Source/modules/serviceworkers/FetchRequestData.cpp - Issue 610403002: [ServiceWorker] Plumbing the request credentials mode to the ServiceWorker. [1/2 blink]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/FetchRequestData.cpp

Issue 610403002: [ServiceWorker] Plumbing the request credentials mode to the ServiceWorker. [1/2 blink] (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: incorporated yhirano's comment Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/serviceworkers/FetchRequestData.cpp

diff --git a/Source/modules/serviceworkers/FetchRequestData.cpp b/Source/modules/serviceworkers/FetchRequestData.cpp

index 63fc78a33baf966fee294ab4a3a5083bde27f7af..f93efcf37a3bd3dcb84065ccb9dc2cd69e655e4d 100644

--- a/Source/modules/serviceworkers/FetchRequestData.cpp

+++ b/Source/modules/serviceworkers/FetchRequestData.cpp

@@ -52,6 +52,19 @@ FetchRequestData* FetchRequestData::create(const WebServiceWorkerRequest& webReq

break;

case WebURLRequest::FetchRequestModeCORSWithForcedPreflight:

request->setMode(FetchRequestData::CORSWithForcedPreflight);

+ default:

+ ASSERT_NOT_REACHED();

Mike West 2014/10/01 08:16:34 Why add the default? Isn't this switch an exhausti

horo 2014/10/01 08:32:21 Removed

+ break;

+ }

+ switch (webRequest.credentialsMode()) {

+ case WebURLRequest::FetchCredentialsModeOmit:

+ request->setCredentials(FetchRequestData::OmitCredentials);

+ break;

+ case WebURLRequest::FetchCredentialsModeSameOrigin:

+ request->setCredentials(FetchRequestData::SameOriginCredentials);

+ break;

+ case WebURLRequest::FetchCredentialsModeInclude:

+ request->setCredentials(FetchRequestData::IncludeCredentials);

break;

default:

ASSERT_NOT_REACHED();

Mike West 2014/10/01 08:16:34 Ditto.

horo 2014/10/01 08:32:21 Removed

« no previous file with comments | « no previous file | Source/platform/exported/WebServiceWorkerRequest.cpp » ('j') | Source/platform/network/ResourceRequest.h » ('J')