[ServiceWorker] Plumbing the request credentials mode to the ServiceWorker. [1/2 blink]

Source/modules/serviceworkers/FetchRequestData.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "FetchRequestData.h"
 
 #include "core/dom/Document.h"
 #include "core/dom/ExecutionContext.h"
 #include "core/fetch/ResourceLoaderOptions.h"
@@ skipping 34 matching lines @@
         request->setMode(FetchRequestData::SameOriginMode);
         break;
     case WebURLRequest::FetchRequestModeNoCORS:
         request->setMode(FetchRequestData::NoCORSMode);
         break;
     case WebURLRequest::FetchRequestModeCORS:
         request->setMode(FetchRequestData::CORSMode);
         break;
     case WebURLRequest::FetchRequestModeCORSWithForcedPreflight:
         request->setMode(FetchRequestData::CORSWithForcedPreflight);
+    default:
+        ASSERT_NOT_REACHED();

[Mike West, 2014/10/01 08:16:34]

Why add the default? Isn't this switch an exhaustive list of FetchRequestMode's
values?

[horo, 2014/10/01 08:32:21]

Removed

+        break;
+    }
+    switch (webRequest.credentialsMode()) {
+    case WebURLRequest::FetchCredentialsModeOmit:
+        request->setCredentials(FetchRequestData::OmitCredentials);
+        break;
+    case WebURLRequest::FetchCredentialsModeSameOrigin:
+        request->setCredentials(FetchRequestData::SameOriginCredentials);
+        break;
+    case WebURLRequest::FetchCredentialsModeInclude:
+        request->setCredentials(FetchRequestData::IncludeCredentials);
         break;
     default:
         ASSERT_NOT_REACHED();

[Mike West, 2014/10/01 08:16:34]

Ditto.

[horo, 2014/10/01 08:32:21]

Removed

         break;
     }
     return request;
 }
 
 FetchRequestData* FetchRequestData::createRestrictedCopy(ExecutionContext* context, PassRefPtr<SecurityOrigin> origin) const
 {
     // "To make a restricted copy of a request |request|, run these steps:
     // 1. Let |r| be a new request whose url is |request|'s url, method is
     // |request|'s method, header list is a copy of |request|'s header list,
@@ skipping 51 matching lines @@
     , m_responseTainting(BasicTainting)
 {
 }
 
 void FetchRequestData::trace(Visitor* visitor)
 {
     visitor->trace(m_headerList);
 }
 
 } // namespace blink