Refactor FrameAndConstantPoolScope and ConstantPoolUnavailableScope to be architecture independent

src/ia32/assembler-ia32.h

Index: src/ia32/assembler-ia32.h
diff --git a/src/ia32/assembler-ia32.h b/src/ia32/assembler-ia32.h
index 7a828c796779ec11ba336a56676a16ea632cd102..04d9b54ab97eed4b7c50fc0583b4264948c4c286 100644
--- a/src/ia32/assembler-ia32.h
+++ b/src/ia32/assembler-ia32.h
@@ -1098,6 +1098,12 @@ class Assembler : public AssemblerBase {
   // Generate the constant pool for the generated code.
   void PopulateConstantPool(ConstantPoolArray* constant_pool);
 
+  bool is_constant_pool_available() const {
+    // Support not implemented in ia32 yet.

[rmcilroy, 2014/09/26 15:54:57]

We will probably never us a constant pool on ia32, so you can just remove the
comment and UNREACHABLE and always return false here.

[baixo, 2014/10/02 09:18:21]

Done.

+    UNREACHABLE();
+    return false;
+  }
+
  protected:
   void emit_sse_operand(XMMRegister reg, const Operand& adr);
   void emit_sse_operand(XMMRegister dst, XMMRegister src);
@@ -1106,6 +1112,17 @@ class Assembler : public AssemblerBase {
 
   byte* addr_at(int pos) { return buffer_ + pos; }
 
+  bool is_const_pool_blocked() const {

[rmcilroy, 2014/09/26 15:54:57]

You don't need this function (that is only for the inline constant pool and will
be going away on Arm once we switch to OOL constant pool).

[baixo, 2014/10/02 09:18:21]

Done.

+    // Support not implemented in ia32 yet.
+    UNREACHABLE();
+    return false;
+  }
+
+  void set_constant_pool_available(bool available) {
+    // Support not implemented in ia32 yet.

[rmcilroy, 2014/09/26 15:54:57]

replace comment with: "// Constant pool is not supported on ia32"

[baixo, 2014/10/02 09:18:21]

Done.

+    UNREACHABLE();
+  }
+
 
  private:
   uint32_t long_at(int pos)  {
@@ -1159,6 +1176,7 @@ class Assembler : public AssemblerBase {
 
   friend class CodePatcher;
   friend class EnsureSpace;
+  friend class FrameAndConstantPoolScope;
 
   // code generation
   RelocInfoWriter reloc_info_writer;