Refactor FrameAndConstantPoolScope and ConstantPoolUnavailableScope to be architecture independent

src/ia32/assembler-ia32.h

 // Copyright (c) 1994-2006 Sun Microsystems Inc.
 // All Rights Reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 // - Redistributions of source code must retain the above copyright notice,
 // this list of conditions and the following disclaimer.
 //
@@ skipping 1080 matching lines @@
 
   byte byte_at(int pos) { return buffer_[pos]; }
   void set_byte_at(int pos, byte value) { buffer_[pos] = value; }
 
   // Allocate a constant pool of the correct size for the generated code.
   Handle<ConstantPoolArray> NewConstantPool(Isolate* isolate);
 
   // Generate the constant pool for the generated code.
   void PopulateConstantPool(ConstantPoolArray* constant_pool);
 
+  bool is_constant_pool_available() const {
+    // Support not implemented in ia32 yet.

[rmcilroy, 2014/09/26 15:54:57]

We will probably never us a constant pool on ia32, so you can just remove the
comment and UNREACHABLE and always return false here.

[baixo, 2014/10/02 09:18:21]

Done.

+    UNREACHABLE();
+    return false;
+  }
+
  protected:
   void emit_sse_operand(XMMRegister reg, const Operand& adr);
   void emit_sse_operand(XMMRegister dst, XMMRegister src);
   void emit_sse_operand(Register dst, XMMRegister src);
   void emit_sse_operand(XMMRegister dst, Register src);
 
   byte* addr_at(int pos) { return buffer_ + pos; }
 
+  bool is_const_pool_blocked() const {

[rmcilroy, 2014/09/26 15:54:57]

You don't need this function (that is only for the inline constant pool and will
be going away on Arm once we switch to OOL constant pool).

[baixo, 2014/10/02 09:18:21]

Done.

+    // Support not implemented in ia32 yet.
+    UNREACHABLE();
+    return false;
+  }
+
+  void set_constant_pool_available(bool available) {
+    // Support not implemented in ia32 yet.

[rmcilroy, 2014/09/26 15:54:57]

replace comment with: "// Constant pool is not supported on ia32"

[baixo, 2014/10/02 09:18:21]

Done.

+    UNREACHABLE();
+  }
+
 
  private:
   uint32_t long_at(int pos)  {
     return *reinterpret_cast<uint32_t*>(addr_at(pos));
   }
   void long_at_put(int pos, uint32_t x)  {
     *reinterpret_cast<uint32_t*>(addr_at(pos)) = x;
   }
 
   // code emission
@@ skipping 33 matching lines @@
   inline Displacement disp_at(Label* L);
   inline void disp_at_put(Label* L, Displacement disp);
   inline void emit_disp(Label* L, Displacement::Type type);
   inline void emit_near_disp(Label* L);
 
   // record reloc info for current pc_
   void RecordRelocInfo(RelocInfo::Mode rmode, intptr_t data = 0);
 
   friend class CodePatcher;
   friend class EnsureSpace;
+  friend class FrameAndConstantPoolScope;
 
   // code generation
   RelocInfoWriter reloc_info_writer;
 
   PositionsRecorder positions_recorder_;
   friend class PositionsRecorder;
 };
 
 
 // Helper class that ensures that there is enough space for generating
@@ skipping 19 matching lines @@
  private:
   Assembler* assembler_;
 #ifdef DEBUG
   int space_before_;
 #endif
 };
 
 } }  // namespace v8::internal
 
 #endif  // V8_IA32_ASSEMBLER_IA32_H_