UI rework for reset options including Rollback.

UI rework for reset options including Rollback.

New flow https://docs.google.com/a/google.com/drawings/d/1pFPcX2XuZ2qQATplGLV0DxpRh-3xZp4nGWBSN-g3V1Y/edit

Rollback option is invoked and hidden (if available) with same key-combination Ctrl+Alt+Shift+R as the reset but only while being on the reset screen.

Screenshots (outdated since patchset 2)
https://drive.google.com/folderview?id=0Bw7YaCAcM6UPdUFVYnk4UGlWSzA&usp=sharing

Screenshots since patchset 2
https://drive.google.com/folderview?id=0Bw7YaCAcM6UPdzllZ3B6amtacmM&usp=sharing

Screenshots since patchset 3
https://drive.google.com/folderview?id=0Bw7YaCAcM6UPR1NLQ2VRSWRtUlk&usp=sharing

Screenshots since patchset 4
https://drive.google.com/folderview?id=0Bw7YaCAcM6UPYjRBWGV6WXVOVkE&usp=sharing

BUG=399186
Committed: https://crrev.com/32b8eb2a2ab9db9f5d4b8da83c6f13132db94ee5
Cr-Commit-Position: refs/heads/master@{#298464}

[merkulova, 2014-09-26 12:21:10]

merkulova@chromium.org changed reviewers:
+ dzhioev@chromium.org

[Nikita (slow), 2014-09-26 13:20:59]

nkostylev@chromium.org changed reviewers:
+ nkostylev@chromium.org

[Nikita (slow), 2014-09-26 13:21:00]

>> Screenshots
https://drive.google.com/a/google.com/folderview?id=0B0Pq_70XQgc1bFV5cTlJbGgz...

Popup border and shadow look a bit out of place.
Please reuse existing CSS, see system security overlay initiated from EULA
screen (attached in bug).

[dzhioev (left Google), 2014-09-29 14:35:43]

https://codereview.chromium.org/609803002/diff/1/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/login/oobe_screen_reset.js (right):

https://codereview.chromium.org/609803002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/oobe_screen_reset.js:1: // Copyright (c)
2012 The Chromium Authors. All rights reserved.
Please use |this| instead of |$('reset')| everywhere in this file.

[merkulova, 2014-10-06 12:40:29]

Overlay style changed to the same one as eula popup uses.

https://codereview.chromium.org/609803002/diff/1/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/login/oobe_screen_reset.js (right):

https://codereview.chromium.org/609803002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/oobe_screen_reset.js:1: // Copyright (c)
2012 The Chromium Authors. All rights reserved.
On 2014/09/29 14:35:43, dzhioev wrote:
> Please use |this| instead of |$('reset')| everywhere in this file.

It's not always the same. For example, it won't work inside button event
listeners functions.

[dzhioev (left Google), 2014-10-06 14:13:26]

LGTM with nit

https://codereview.chromium.org/609803002/diff/20001/chrome/browser/resources...
File
chrome/browser/resources/chromeos/login/oobe_screen_reset_confirmation_overlay.js
(right):

https://codereview.chromium.org/609803002/diff/20001/chrome/browser/resources...
chrome/browser/resources/chromeos/login/oobe_screen_reset_confirmation_overlay.js:5:
cr.define('reset', function() {
nit: I don't think we need a new namespace for ConfirmResetOverlay. Let's put it
in 'login' namespace.

[Nikita (slow), 2014-10-06 15:17:03]

>> Screenshots since patchset 2
https://drive.google.com/a/google.com/folderview?id=0B0Pq_70XQgc1Z3FoemJQMkNj...

Are these screenshots latest ones?
They seem to use same CSS for dialog overlay.

[merkulova, 2014-10-07 08:24:04]

Css fixed. Screenshots updated.

[Nikita (slow), 2014-10-07 08:35:00]

On 2014/10/07 08:24:04, merkulova wrote:
> Css fixed. Screenshots updated.

Thanks, nits per screenshots.

PowerwashConfirm: space between buttons on a dialog (Continue / Cancel) should
be the same as space between buttons on screen.
Rollback promise: spinner is not centered with text.

String nits:

RollbackConfirm: remove dot from the header string

Now let's compare

Powerwash.jpg: two strings on the dialog, both have dot at the end. (ok)
PowerwashAndRollback.jpg: first string doesn't have dot at the end, second one
does. I guess both should have a dot at the end.

Rollback promise.jpg: I would suggest dropping dot from the "Chrome will restart
and reset momentarily." otherwise it is the only string on the screen with a dot
at the end.

[merkulova, 2014-10-07 10:54:19]

Nits fixed.

[Nikita (slow), 2014-10-07 12:19:17]

lgtm

[merkulova, 2014-10-07 12:20:11]

The CQ bit was checked by merkulova@chromium.org

[commit-bot: I haz the power, 2014-10-07 12:21:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/609803002/60001

[commit-bot: I haz the power, 2014-10-07 13:30:52]

Committed patchset #4 (id:60001) as 5bcd3509d14c77578bcaf00969ec4b80c86501ce

[commit-bot: I haz the power, 2014-10-07 13:31:31]

Patchset 4 (id:??) landed as
https://crrev.com/32b8eb2a2ab9db9f5d4b8da83c6f13132db94ee5
Cr-Commit-Position: refs/heads/master@{#298464}

[Nikita (slow), 2014-10-08 09:09:38]

Btw, I've tried accessing screenshots from incognito window and it seems that
you need to change folder permissings to "anyone with a link".