Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Unified Diff: ui/login/display_manager.js

Issue 609803002: UI rework for reset options including Rollback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Strings and views nits. Rollback view is unset on screen cancel. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc ('k') | ui/login/oobe.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/login/display_manager.js
diff --git a/ui/login/display_manager.js b/ui/login/display_manager.js
index d2c0b6f8d99e0cf7f65fd513816301ffbfde1d35..8f8c60d071020564d3424630d8543b48199ff925 100644
--- a/ui/login/display_manager.js
+++ b/ui/login/display_manager.js
@@ -46,10 +46,6 @@
/** @const */ var ACCELERATOR_APP_LAUNCH_BAILOUT = 'app_launch_bailout';
/** @const */ var ACCELERATOR_APP_LAUNCH_NETWORK_CONFIG =
'app_launch_network_config';
-/** @const */ var ACCELERATOR_SHOW_ROLLBACK_ON_RESET =
- 'show_rollback_on_reset_screen';
-/** @const */ var ACCELERATOR_HIDE_ROLLBACK_ON_RESET =
- 'hide_rollback_on_reset_screen';
/* Signin UI state constants. Used to control header bar UI. */
/** @const */ var SIGNIN_UI_STATE = {
@@ -357,7 +353,9 @@ cr.define('cr.ui.login', function() {
if (this.allowToggleVersion_)
$('version-labels').hidden = !$('version-labels').hidden;
} else if (name == ACCELERATOR_RESET) {
- if (RESET_AVAILABLE_SCREEN_GROUP.indexOf(currentStepId) != -1)
+ if (currentStepId == SCREEN_OOBE_RESET)
+ chrome.send('toggleRollbackOnResetScreen');
+ else if (RESET_AVAILABLE_SCREEN_GROUP.indexOf(currentStepId) != -1)
chrome.send('toggleResetScreen');
} else if (name == ACCELERATOR_DEVICE_REQUISITION) {
if (this.isOobeUI())
@@ -376,12 +374,6 @@ cr.define('cr.ui.login', function() {
} else if (name == ACCELERATOR_APP_LAUNCH_NETWORK_CONFIG) {
if (currentStepId == SCREEN_APP_LAUNCH_SPLASH)
chrome.send('networkConfigRequest');
- } else if (name == ACCELERATOR_SHOW_ROLLBACK_ON_RESET) {
- if (currentStepId == SCREEN_OOBE_RESET)
- chrome.send('showRollbackOnResetScreen');
- } else if (name == ACCELERATOR_HIDE_ROLLBACK_ON_RESET) {
- if (currentStepId == SCREEN_OOBE_RESET)
- chrome.send('hideRollbackOnResetScreen');
}
if (!this.forceKeyboardFlow_)
« no previous file with comments | « chrome/browser/ui/webui/chromeos/login/reset_screen_handler.cc ('k') | ui/login/oobe.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698