Chromium Code Reviews
Help | Chromium Project | Sign in
(381)

Issue 6098009: Make sure the histogram counters for about:conflicts get uploaded.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 6 months ago by Finnur (OOO - vacation)
Modified:
4 years, 1 month ago
CC:
chromium-reviews
Visibility:
Public.

Description

Make sure the histogram counters for about:conflicts get uploaded. BUG=51105 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=70860

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -16 lines) Patch
M chrome/browser/enumerate_modules_model_win.cc View 1 3 chunks +18 lines, -16 lines 0 comments Download
Commit: CQ not working?

Messages

Total messages: 4 (0 generated)
Finnur (OOO - vacation)
4 years, 6 months ago (2011-01-07 22:03:34 UTC) #1
jar (doing other things)
Please see nit below. Note that the call to push your sample into the histogram ...
4 years, 6 months ago (2011-01-08 00:00:59 UTC) #2
Finnur (OOO - vacation)
Yeah, it is not critical in this case, but I have made the change nonetheless. ...
4 years, 6 months ago (2011-01-09 12:54:40 UTC) #3
jar (doing other things)
4 years, 6 months ago (2011-01-09 15:17:06 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 5fa3ca5