Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2891)

Unified Diff: chrome/browser/enumerate_modules_model_win.cc

Issue 6098009: Make sure the histogram counters for about:conflicts get uploaded.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/enumerate_modules_model_win.cc
===================================================================
--- chrome/browser/enumerate_modules_model_win.cc (revision 70751)
+++ chrome/browser/enumerate_modules_model_win.cc (working copy)
@@ -345,23 +345,25 @@
// Make sure the path mapping vector is setup so we can collapse paths.
PreparePathMappings();
- base::TimeTicks checkpoint = base::TimeTicks::Now();
-
// Enumerating loaded modules must happen first since the other types of
// modules check for duplication against the loaded modules.
+ base::TimeTicks checkpoint = base::TimeTicks::Now();
EnumerateLoadedModules();
- HISTOGRAM_TIMES("Conflicts.EnumerateLoadedModules",
- base::TimeTicks::Now() - checkpoint);
+ base::TimeTicks checkpoint2 = base::TimeTicks::Now();
+ UMA_HISTOGRAM_TIMES("Conflicts.EnumerateLoadedModules",
+ checkpoint2 - checkpoint);
- checkpoint = base::TimeTicks::Now();
+ checkpoint = checkpoint2;
EnumerateShellExtensions();
- HISTOGRAM_TIMES("Conflicts.EnumerateShellExtensions",
- base::TimeTicks::Now() - checkpoint);
+ checkpoint2 = base::TimeTicks::Now();
+ UMA_HISTOGRAM_TIMES("Conflicts.EnumerateShellExtensions",
+ checkpoint2 - checkpoint);
- checkpoint = base::TimeTicks::Now();
+ checkpoint = checkpoint2;
EnumerateWinsockModules();
- HISTOGRAM_TIMES("Conflicts.EnumerateWinsockModules",
- base::TimeTicks::Now() - checkpoint);
+ checkpoint2 = base::TimeTicks::Now();
+ UMA_HISTOGRAM_TIMES("Conflicts.EnumerateWinsockModules",
+ checkpoint2 - checkpoint);
MatchAgainstBlacklist();
@@ -378,8 +380,8 @@
ReportBack();
}
- HISTOGRAM_TIMES("Conflicts.EnumerationTotalTime",
- base::TimeTicks::Now() - start_time);
+ UMA_HISTOGRAM_TIMES("Conflicts.EnumerationTotalTime",
+ base::TimeTicks::Now() - start_time);
}
void ModuleEnumerator::EnumerateLoadedModules() {
@@ -837,10 +839,10 @@
scanning_ = false;
lock->Release();
- HISTOGRAM_COUNTS_100("Conflicts.SuspectedBadModules",
- suspected_bad_modules_detected_);
- HISTOGRAM_COUNTS_100("Conflicts.ConfirmedBadModules",
- confirmed_bad_modules_detected_);
+ UMA_HISTOGRAM_COUNTS_100("Conflicts.SuspectedBadModules",
+ suspected_bad_modules_detected_);
+ UMA_HISTOGRAM_COUNTS_100("Conflicts.ConfirmedBadModules",
+ confirmed_bad_modules_detected_);
// Notifications are not available in limited mode.
if (limited_mode_)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698