Issue 6098008: AU: Include a bit flag (bit 31) in error codes to indicate non-normal boot mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6098008: AU: Include a bit flag (bit 31) in error codes to indicate non-normal boot mode. (Closed)

Created:
9 years, 11 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
adlr

CC:
chromium-os-reviews_chromium.org, petkov, adlr

Base URL:
ssh://git@gitrw.chromium.org:9222/update_engine.git@master

Visibility:
Public.

Description

AU: Include a bit flag (bit 31) in error codes to indicate non-normal boot mode. BUG=chromium-os:10320 TEST=unit test, tested on device in normal and dev mode Change-Id: I67d695bc167a4cc1a638711f047e2b86f8eaa8f1 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=c91dd6b

Patch Set 1 #

Total comments: 2

Patch Set 2 : review #

Created: 9 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -24 lines)			Patch
M	SConstruct	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	action_processor.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	omaha_request_action.cc	View		1 chunk	+7 lines, -3 lines	0 comments	Download
M	omaha_request_action_unittest.cc	View		1 chunk	+1 line, -21 lines	0 comments	Download
M	setup_dev_packages	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	utils.h	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	utils.cc	View	1	2 chunks	+10 lines, -0 lines	0 comments	Download
M	utils_unittest.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

adlr

LGTM w/ nit. thanks for the CL! http://codereview.chromium.org/6098008/diff/1/utils.cc File utils.cc (right): http://codereview.chromium.org/6098008/diff/1/utils.cc#newcode55 utils.cc:55: mode.Initialize(false, true); ...

9 years, 11 months ago (2011-01-07 22:44:08 UTC) #2

petkov

9 years, 11 months ago (2011-01-07 22:50:45 UTC) #3

thanks. will push when you lgtm the ebuild change.

http://codereview.chromium.org/6098008/diff/1/utils.cc
File utils.cc (right):

http://codereview.chromium.org/6098008/diff/1/utils.cc#newcode55
utils.cc:55: mode.Initialize(false, true);
On 2011/01/07 22:44:08, adlr wrote:
> perhaps a comment about what false, true means?

Done.

Expand Messages | Collapse Messages