Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: omaha_request_action_unittest.cc

Issue 6098008: AU: Include a bit flag (bit 31) in error codes to indicate non-normal boot mode. (Closed) Base URL: ssh://git@gitrw.chromium.org:9222/update_engine.git@master
Patch Set: review Created 9 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « omaha_request_action.cc ('k') | setup_dev_packages » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: omaha_request_action_unittest.cc
diff --git a/omaha_request_action_unittest.cc b/omaha_request_action_unittest.cc
index 4ac2b745f149298093e90518516c4cbc88ead765..8082e1567f237eedfc40a96ca825364eb097eec2 100755
--- a/omaha_request_action_unittest.cc
+++ b/omaha_request_action_unittest.cc
@@ -603,27 +603,7 @@ TEST(OmahaRequestActionTest, FormatErrorEventOutputTest) {
"errorcode=\"%d\"></o:event>\n",
OmahaEvent::kTypeDownloadComplete,
OmahaEvent::kResultError,
- kActionCodeError);
- EXPECT_NE(post_str.find(expected_event), string::npos);
- EXPECT_EQ(post_str.find("o:updatecheck"), string::npos);
-}
-
-TEST(OmahaRequestActionTest, FormatEventOutputTest) {
- vector<char> post_data;
- TestEvent(kDefaultTestParams,
- new OmahaEvent(OmahaEvent::kTypeDownloadComplete,
- OmahaEvent::kResultError,
- kActionCodeError),
- "invalid xml>",
- &post_data);
- // convert post_data to string
- string post_str(&post_data[0], post_data.size());
- string expected_event = StringPrintf(
- " <o:event eventtype=\"%d\" eventresult=\"%d\" "
- "errorcode=\"%d\"></o:event>\n",
- OmahaEvent::kTypeDownloadComplete,
- OmahaEvent::kResultError,
- kActionCodeError);
+ kActionCodeError | kActionCodeBootModeFlag);
EXPECT_NE(post_str.find(expected_event), string::npos);
EXPECT_EQ(post_str.find("o:updatecheck"), string::npos);
}
« no previous file with comments | « omaha_request_action.cc ('k') | setup_dev_packages » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698