Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 609733003: [Autofill Clean up] Revert changes introduced by Autocheckout to autofill (Closed)

Created:
6 years, 2 months ago by ziran.sun
Modified:
6 years, 2 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, jam, darin-cc_chromium.org, Dane Wallinga, dyu1, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Autofill Clean up] Revert changes introduced by Autocheckout to autofill disabled and readonly fields. Autocheckout is deprecated. R=isherman@chromium.org BUG=231160 Committed: https://crrev.com/d9b040ba4ff2ff78f183816b9d0e34c5f450160c Cr-Commit-Position: refs/heads/master@{#297015}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -45 lines) Patch
M chrome/renderer/autofill/form_autofill_browsertest.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M components/autofill/content/renderer/form_autofill_util.h View 1 chunk +0 lines, -6 lines 0 comments Download
M components/autofill/content/renderer/form_autofill_util.cc View 6 chunks +7 lines, -34 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
ziran.sun
Please review. Thanks!
6 years, 2 months ago (2014-09-26 12:18:37 UTC) #1
Ilya Sherman
LGTM. Thanks!
6 years, 2 months ago (2014-09-26 19:15:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/609733003/1
6 years, 2 months ago (2014-09-26 19:17:16 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as c16f749995aaa3033e7bc82ca7b9f672ec422350
6 years, 2 months ago (2014-09-26 20:01:48 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d9b040ba4ff2ff78f183816b9d0e34c5f450160c Cr-Commit-Position: refs/heads/master@{#297015}
6 years, 2 months ago (2014-09-26 20:02:33 UTC) #6
Evan Stade
This patch is incorrect; I believe it breaks requestAutocomplete and should be reverted. requestAutocomplete does ...
6 years, 2 months ago (2014-10-13 16:56:56 UTC) #7
Evan Stade
6 years, 2 months ago (2014-10-13 18:35:09 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/648243003/ by estade@chromium.org.

The reason for reverting is: these changes are still necessary for
requestAutocomplete.

Powered by Google App Engine
This is Rietveld 408576698