Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 609733002: Replace peerconnection.html with a redirect to github. (Closed)

Created:
6 years, 2 months ago by jansson
Modified:
6 years, 2 months ago
CC:
chromium-reviews, tnakamura
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replace peerconnection.html with a redirect to github. Removed all other manual test files in the ../webrtc/manual folder. They too have moved to GitHub but are not used that often hence no redirect pages are necessary. The ../webrtc/manual folder now resides here: https://github.com/GoogleChrome/webrtc/tree/master/samples/web/content/manual-test BUG=NONE NOTRY=TRUE Committed: https://crrev.com/bcdf9a3bf14ba30f3e7a2ed41cacae536378040a Cr-Commit-Position: refs/heads/master@{#297156}

Patch Set 1 : Fixed links #

Patch Set 2 : added doc type #

Total comments: 4

Patch Set 3 : Fixed HTML errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -2338 lines) Patch
D chrome/test/data/webrtc/manual/constraints.html View 1 chunk +0 lines, -64 lines 0 comments Download
D chrome/test/data/webrtc/manual/constraints.js View 1 chunk +0 lines, -150 lines 0 comments Download
M chrome/test/data/webrtc/manual/peerconnection.html View 1 2 1 chunk +20 lines, -177 lines 0 comments Download
D chrome/test/data/webrtc/manual/peerconnection-help.html View 1 chunk +0 lines, -105 lines 0 comments Download
D chrome/test/data/webrtc/manual/peerconnection-iframe.html View 1 chunk +0 lines, -10 lines 0 comments Download
D chrome/test/data/webrtc/manual/peerconnection-multi.html View 1 chunk +0 lines, -282 lines 0 comments Download
D chrome/test/data/webrtc/manual/peerconnection_manual.js View 1 chunk +0 lines, -1425 lines 0 comments Download
D chrome/test/data/webrtc/manual/stylesheet.css View 1 chunk +0 lines, -125 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
jansson
Please take a quick look, do you think it's necessary to do redirects for all ...
6 years, 2 months ago (2014-09-29 08:09:56 UTC) #4
jansson
Forgot to include the doc type.
6 years, 2 months ago (2014-09-29 08:13:57 UTC) #5
kjellander_chromium
lgtm assuming you fix the simple HTML errors so the page is at least somewhat ...
6 years, 2 months ago (2014-09-29 08:34:18 UTC) #6
jansson
Sorry for the rudimentary errors. https://codereview.chromium.org/609733002/diff/60001/chrome/test/data/webrtc/manual/peerconnection.html File chrome/test/data/webrtc/manual/peerconnection.html (right): https://codereview.chromium.org/609733002/diff/60001/chrome/test/data/webrtc/manual/peerconnection.html#newcode12 chrome/test/data/webrtc/manual/peerconnection.html:12: <center> On 2014/09/29 08:34:18, ...
6 years, 2 months ago (2014-09-29 09:52:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/609733002/80001
6 years, 2 months ago (2014-09-29 11:11:08 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:80001) as f0fb42983310e35c1ebbce0a5b0ea9324566b326
6 years, 2 months ago (2014-09-29 11:11:35 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 11:13:25 UTC) #11
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/bcdf9a3bf14ba30f3e7a2ed41cacae536378040a
Cr-Commit-Position: refs/heads/master@{#297156}

Powered by Google App Engine
This is Rietveld 408576698