Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 609403003: Move offset and CTM from LayerCache Key to per-hoisted-layer info (Closed)

Created:
6 years, 2 months ago by robertphillips
Modified:
6 years, 2 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Move offset and CTM from LayerCache Key to per-hoisted-layer info This CL reduces the amount of information used in the layer cache key: - the stop value isn't needed since the start value uniquely identifies the layer in the picture. - only the upper-left 2x2 portion of the CTM should be used as a key for looking up cached layers. - individual layers can be redraw in different locations so the final offset cannot be a part of the key. Since this data is no longer stored in the cached layer, but is still required to draw the cached layer, it is now stored in the per-layer information (i.e., HoistedLayer). This is split out of (Fix sub-picture layer rendering bugs - https://codereview.chromium.org/597293002/). BUG=skia:2315 Committed: https://skia.googlesource.com/skia/+/ed42059d2f97d4f8d247af3cbf5dc290c32785eb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -77 lines) Patch
M src/gpu/GrLayerCache.h View 6 chunks +23 lines, -33 lines 0 comments Download
M src/gpu/GrLayerCache.cpp View 2 chunks +7 lines, -10 lines 0 comments Download
M src/gpu/GrLayerHoister.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/gpu/GrLayerHoister.cpp View 9 chunks +26 lines, -20 lines 0 comments Download
M tests/GpuLayerCacheTest.cpp View 6 chunks +7 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
robertphillips
6 years, 2 months ago (2014-09-29 17:46:39 UTC) #2
robertphillips
6 years, 2 months ago (2014-09-29 17:46:41 UTC) #3
egdaniel
lgtm
6 years, 2 months ago (2014-09-29 18:20:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/609403003/1
6 years, 2 months ago (2014-09-29 18:32:32 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 18:39:41 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as ed42059d2f97d4f8d247af3cbf5dc290c32785eb

Powered by Google App Engine
This is Rietveld 408576698