Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 609343002: xml-roles for input types {radio, range, button}, math (Closed)

Created:
6 years, 2 months ago by shreeramk
Modified:
6 years, 2 months ago
Reviewers:
dmazzoni, Mike West
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

xml-roles for input types {radio, range, button}, math According to latest editor draft(http://rawgit.com/w3c/html-api-map/master/index.html) above mentioned input type attributes should have xml-roles. Also math tag should have xml-role. BUG=418486 Committed: https://crrev.com/bbbdcec8301e5ff9b8273e3e27ff7426d9dacfa7 Cr-Commit-Position: refs/heads/master@{#297817}

Patch Set 1 #

Patch Set 2 : Adding test in dump AX #

Patch Set 3 : Adding expectations for mac #

Patch Set 4 : #

Patch Set 5 : #

Messages

Total messages: 23 (7 generated)
shreeramk
Please review. I ll update the failing win test tomorrow. Thanks!
6 years, 2 months ago (2014-09-29 15:32:04 UTC) #2
shreeramk
On 2014/09/29 15:32:04, shreeram.k wrote: > Please review. > > I ll update the failing ...
6 years, 2 months ago (2014-09-29 15:34:05 UTC) #3
shreeramk
On 2014/09/29 15:34:05, shreeram.k wrote: > On 2014/09/29 15:32:04, shreeram.k wrote: > > Please review. ...
6 years, 2 months ago (2014-10-01 05:44:07 UTC) #4
shreeramk
Updated the CL. Please review. Thanks!
6 years, 2 months ago (2014-10-01 08:10:13 UTC) #5
Mike West
1. There's no test for the math role you added. 2. Can you point to ...
6 years, 2 months ago (2014-10-01 18:46:28 UTC) #7
dmazzoni
On 2014/10/01 18:46:28, Mike West wrote: > 1. There's no test for the math role ...
6 years, 2 months ago (2014-10-01 19:09:07 UTC) #8
dmazzoni
lgtm
6 years, 2 months ago (2014-10-01 19:36:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/609343002/80001
6 years, 2 months ago (2014-10-01 19:38:06 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/18118)
6 years, 2 months ago (2014-10-01 21:47:24 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/609343002/80001
6 years, 2 months ago (2014-10-02 06:35:23 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_swarming/builds/18271)
6 years, 2 months ago (2014-10-02 07:01:46 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/609343002/80001
6 years, 2 months ago (2014-10-02 11:45:11 UTC) #19
shreeramk
On 2014/10/01 18:46:28, Mike West wrote: > 1. There's no test for the math role ...
6 years, 2 months ago (2014-10-02 12:26:18 UTC) #20
Mike West
On 2014/10/02 12:26:18, shreeram.k wrote: > On 2014/10/01 18:46:28, Mike West wrote: > > 1. ...
6 years, 2 months ago (2014-10-02 12:28:58 UTC) #21
commit-bot: I haz the power
Committed patchset #5 (id:80001) as bfdbfcd83191122231e0e7b8d5a7de56c32dbdde
6 years, 2 months ago (2014-10-02 12:50:57 UTC) #22
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 12:51:35 UTC) #23
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/bbbdcec8301e5ff9b8273e3e27ff7426d9dacfa7
Cr-Commit-Position: refs/heads/master@{#297817}

Powered by Google App Engine
This is Rietveld 408576698