content/renderer/accessibility/blink_ax_tree_source.cc - Issue 609343002: xml-roles for input types {radio, range, button}, math

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/accessibility/blink_ax_tree_source.cc

Issue 609343002: xml-roles for input types {radio, range, button}, math (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/dump_accessibility_tree_browsertest.cc ('k') | content/test/data/accessibility/input-button.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/accessibility/blink_ax_tree_source.cc

diff --git a/content/renderer/accessibility/blink_ax_tree_source.cc b/content/renderer/accessibility/blink_ax_tree_source.cc

index 994550f32e8ef5396e158b04638d1fb2bfc3cfd4..80e8dca62e6ed0b00c6acbcb03ef8397ecdccea4 100644

--- a/content/renderer/accessibility/blink_ax_tree_source.cc

+++ b/content/renderer/accessibility/blink_ax_tree_source.cc

@@ -70,6 +70,8 @@ std::string GetEquivalentAriaRoleString(const ui::AXRole role) {

return "article";

case ui::AX_ROLE_BANNER:

return "banner";

+ case ui::AX_ROLE_BUTTON:

+ return "button";

case ui::AX_ROLE_COMPLEMENTARY:

return "complementary";

case ui::AX_ROLE_CONTENT_INFO:

@@ -81,10 +83,16 @@ std::string GetEquivalentAriaRoleString(const ui::AXRole role) {

return "img";

case ui::AX_ROLE_MAIN:

return "main";

+ case ui::AX_ROLE_MATH_ELEMENT:

+ return "math";

case ui::AX_ROLE_NAVIGATION:

return "navigation";

+ case ui::AX_ROLE_RADIO_BUTTON:

+ return "radio";

case ui::AX_ROLE_REGION:

return "region";

+ case ui::AX_ROLE_SLIDER:

+ return "slider";

default:

break;

}