When switching the visible uber frame, also switch focus.

When switching the visible uber frame, also switch focus.

BUG=414595
Committed: https://crrev.com/5df63fb842aac0b01a62dd28e4e57473e92bc184
Cr-Commit-Position: refs/heads/master@{#297238}

[Evan Stade, 2014-09-26 20:41:24]

estade@chromium.org changed reviewers:
+ dbeam@chromium.org, mlerman@chromium.org

[Mike Lerman, 2014-09-26 20:52:18]

fixes the issue correctly, so lgtm

Thanks, Evan!

[Dan Beam, 2014-09-27 00:36:18]

https://codereview.chromium.org/608923002/diff/1/chrome/browser/resources/ube...
File chrome/browser/resources/uber/uber.js (right):

https://codereview.chromium.org/608923002/diff/1/chrome/browser/resources/ube...
chrome/browser/resources/uber/uber.js:370:
uber.invokeMethodOnWindow(selectedFrame.contentWindow, 'frameSelected');
if (!selectedFrame.contentDocument.hasFocus())

[Evan Stade, 2014-09-29 15:24:24]

https://codereview.chromium.org/608923002/diff/1/chrome/browser/resources/ube...
File chrome/browser/resources/uber/uber.js (right):

https://codereview.chromium.org/608923002/diff/1/chrome/browser/resources/ube...
chrome/browser/resources/uber/uber.js:370:
uber.invokeMethodOnWindow(selectedFrame.contentWindow, 'frameSelected');
On 2014/09/27 00:36:17, Dan Beam wrote:
> if (!selectedFrame.contentDocument.hasFocus())

what is the difference between having this check and not having this check?

[Dan Beam, 2014-09-29 19:15:47]

lgtm

https://codereview.chromium.org/608923002/diff/1/chrome/browser/resources/ube...
File chrome/browser/resources/uber/uber.js (right):

https://codereview.chromium.org/608923002/diff/1/chrome/browser/resources/ube...
chrome/browser/resources/uber/uber.js:370:
uber.invokeMethodOnWindow(selectedFrame.contentWindow, 'frameSelected');
On 2014/09/29 15:24:24, Evan Stade wrote:
> On 2014/09/27 00:36:17, Dan Beam wrote:
> > if (!selectedFrame.contentDocument.hasFocus())
> 
> what is the difference between having this check and not having this check?

i believed this might break auto-focused fields (e.g. search in settings) and/or
double-focus a frame, but in trying it myself:
a) you can't access the contentDocument easily anyway (it seems)
b) re-focusing a window with focus doesn't dispatch another event

[Evan Stade, 2014-09-29 19:24:34]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2014-09-29 19:25:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/608923002/1

[commit-bot: I haz the power, 2014-09-29 19:40:34]

Committed patchset #1 (id:1) as e0bc4fb380e732d865a5dad76822b925866e5a70

[commit-bot: I haz the power, 2014-09-29 19:41:25]

Patchset 1 (id:??) landed as
https://crrev.com/5df63fb842aac0b01a62dd28e4e57473e92bc184
Cr-Commit-Position: refs/heads/master@{#297238}