Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Unified Diff: chrome/browser/resources/uber/uber.js

Issue 608923002: When switching the visible uber frame, also switch focus. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/uber/uber.js
diff --git a/chrome/browser/resources/uber/uber.js b/chrome/browser/resources/uber/uber.js
index fde61ed74b77abf291558901bfc05ca4eb4d5b30..23417eaf749730ef678913687bc3b3310795a586 100644
--- a/chrome/browser/resources/uber/uber.js
+++ b/chrome/browser/resources/uber/uber.js
@@ -368,6 +368,7 @@ cr.define('uber', function() {
var selectedFrame = getSelectedIframe().querySelector('iframe');
uber.invokeMethodOnWindow(selectedFrame.contentWindow, 'frameSelected');
Dan Beam 2014/09/27 00:36:17 if (!selectedFrame.contentDocument.hasFocus())
Evan Stade 2014/09/29 15:24:24 what is the difference between having this check a
Dan Beam 2014/09/29 19:15:47 i believed this might break auto-focused fields (e
+ selectedFrame.contentWindow.focus();
if (historyOption != HISTORY_STATE_OPTION.NONE)
changePathTo({}, path, historyOption);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698