Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 608613002: Increase buffer size for XMPP sockets. (Closed)

Created:
6 years, 2 months ago by Sergey Ulanov
Modified:
6 years, 2 months ago
Reviewers:
rmsousa
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Increase buffer size for XMPP sockets. Previously 4096 bytes write buffer was used for XMPP socket. Problem is that ChromeAsyncSocket stops writing when the buffer is full and talk::XmppClient ignores this error, as result random chunks of data may be lost. This CL increses buffer size to 64k - same value that's used in notifier::XmppConnection. This is essentially a temporary workaround until the problem is fixed in jingle::ChromeAsyncSocket or talk::XmppClient BUG=417336 Committed: https://crrev.com/4f18b99844271e085918cdcfab318ecede81f135 Cr-Commit-Position: refs/heads/master@{#296805}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M remoting/signaling/xmpp_signal_strategy.cc View 1 chunk +10 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Sergey Ulanov
6 years, 2 months ago (2014-09-25 19:10:06 UTC) #2
rmsousa
lgtm Lgtm
6 years, 2 months ago (2014-09-25 20:22:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/608613002/1
6 years, 2 months ago (2014-09-25 20:36:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 1e9218e387859e3bb0ebefa101f205b2acf81f80
6 years, 2 months ago (2014-09-25 22:09:17 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-25 22:11:22 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f18b99844271e085918cdcfab318ecede81f135
Cr-Commit-Position: refs/heads/master@{#296805}

Powered by Google App Engine
This is Rietveld 408576698