Increase buffer size for XMPP sockets.

remoting/signaling/xmpp_signal_strategy.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/signaling/xmpp_signal_strategy.h"
 
 #include "base/bind.h"
 #include "base/location.h"
 #include "base/logging.h"
 #include "base/single_thread_task_runner.h"
 #include "base/strings/string_util.h"
 #include "base/thread_task_runner_handle.h"
 #include "jingle/glue/chrome_async_socket.h"
 #include "jingle/glue/task_pump.h"
 #include "jingle/glue/xmpp_client_socket_factory.h"
 #include "jingle/notifier/base/gaia_constants.h"
 #include "jingle/notifier/base/gaia_token_pre_xmpp_auth.h"
 #include "net/socket/client_socket_factory.h"
 #include "net/url_request/url_request_context_getter.h"
 #include "third_party/libjingle/source/talk/xmpp/prexmppauth.h"
 #include "third_party/libjingle/source/talk/xmpp/saslcookiemechanism.h"
 #include "third_party/webrtc/base/thread.h"
 
 const char kDefaultResourceName[] = "chromoting";
 
 // Use 58 seconds keep-alive interval, in case routers terminate
 // connections that are idle for more than a minute.
 const int kKeepAliveIntervalSeconds = 50;
 
-// Read buffer size used by ChromeAsyncSocket for read and write buffers. Most
-// of XMPP messages are smaller than 4kB.
-const size_t kReadBufferSize = 4096;
-const size_t kWriteBufferSize = 4096;
+// Read buffer size used by ChromeAsyncSocket for read and write buffers.
+//
+// TODO(sergeyu): Currently jingle::ChromeAsyncSocket fails Write() when the
+// write buffer is full and talk::XmppClient just ignores the error. As result
+// chunks of data sent to the server are dropped (and they may not be full XMPP
+// stanzas). The problem needs to be fixed either in XmppClient on
+// ChromeAsyncSocket (e.g. ChromeAsyncSocket could close the connection when
+// buffer is full).
+const size_t kReadBufferSize = 64 * 1024;
+const size_t kWriteBufferSize = 64 * 1024;
 
 namespace remoting {
 
 XmppSignalStrategy::XmppServerConfig::XmppServerConfig() {}
 XmppSignalStrategy::XmppServerConfig::~XmppServerConfig() {}
 
 XmppSignalStrategy::XmppSignalStrategy(
     net::ClientSocketFactory* socket_factory,
     scoped_refptr<net::URLRequestContextGetter> request_context_getter,
     const XmppSignalStrategy::XmppServerConfig& xmpp_server_config)
@@ skipping 198 matching lines @@
   std::string mechanism = notifier::kDefaultGaiaAuthMechanism;
   if (settings.token_service() == "oauth2") {
     mechanism = "X-OAUTH2";
   }
 
   return new notifier::GaiaTokenPreXmppAuth(
       jid.Str(), settings.auth_token(), settings.token_service(), mechanism);
 }
 
 }  // namespace remoting