Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 608593003: Have ServiceWorkerCache::Put return a Response when completed. (Closed)

Created:
6 years, 2 months ago by jkarlin
Modified:
6 years, 2 months ago
Reviewers:
michaeln, horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@put_context
Project:
chromium
Visibility:
Public.

Description

Have ServiceWorkerCache::Put return a Response when completed. This gets Put() closer to the cache spec. Downstream of: https://codereview.chromium.org/606843002/ BUG=392621 Committed: https://crrev.com/76de75164c1411d93b24d8e8be523c1d31bdd4bd Cr-Commit-Position: refs/heads/master@{#297173}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -18 lines) Patch
M content/browser/service_worker/service_worker_cache.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_cache.cc View 1 11 chunks +42 lines, -13 lines 0 comments Download
M content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_cache_unittest.cc View 2 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
jkarlin
michaeln@chromium.org: Please review changes in everything horo@chromium.org: Please review changes in everything Thanks!
6 years, 2 months ago (2014-09-25 19:42:35 UTC) #2
horo
lgtm
6 years, 2 months ago (2014-09-29 03:14:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/608593003/20001
6 years, 2 months ago (2014-09-29 13:24:37 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/8029)
6 years, 2 months ago (2014-09-29 14:37:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/608593003/20001
6 years, 2 months ago (2014-09-29 15:02:35 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 47f33cd529acc0e73444de8e3c00d6a90c7df777
6 years, 2 months ago (2014-09-29 15:03:22 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 15:04:27 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/76de75164c1411d93b24d8e8be523c1d31bdd4bd
Cr-Commit-Position: refs/heads/master@{#297173}

Powered by Google App Engine
This is Rietveld 408576698