content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc - Issue 608593003: Have ServiceWorkerCache::Put return a Response when completed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc

Issue 608593003: Have ServiceWorkerCache::Put return a Response when completed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@put_context

Patch Set: Rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_cache.cc ('k') | content/browser/service_worker/service_worker_cache_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc

diff --git a/content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc b/content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc

index de8a58ad3b81894661ba18bd1f4bf23777ae9d5a..64bc6cb49e5f1cfc86181b04ff453bf4fcdd085a 100644

--- a/content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc

+++ b/content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc

@@ -91,7 +91,9 @@ class ServiceWorkerCacheStorageManagerTest : public testing::Test {

}

void CachePutCallback(base::RunLoop* run_loop,

- ServiceWorkerCache::ErrorType error) {

+ ServiceWorkerCache::ErrorType error,

+ scoped_ptr<ServiceWorkerResponse> response,

+ scoped_ptr<storage::BlobDataHandle> blob_data_handle) {

callback_cache_error_ = error;

run_loop->Quit();

}