Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Issue 608503005: Revert of cc: Remove use of PassAs() and constructor-casting with scoped_ptr. (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
CC:
cc-bugs_chromium.org, chromium-reviews, erikwright+watch_chromium.org, feature-media-reviews_chromium.org, gavinp+memory_chromium.org, jamesr, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Remove use of PassAs() and constructor-casting with scoped_ptr. (patchset #6 id:120001 of https://codereview.chromium.org/609663003/) Reason for revert: scoped_ptr nullptr support needs to be reverted Original issue's description: > cc: Remove use of PassAs() and constructor-casting with scoped_ptr. > > Say you have class A and subclass B. > > Previously it was required to PassAs() a scoped_ptr<B> into a > scoped_ptr<A>. This is no longer needed, so just use Pass(). For newly > created scoped_ptrs, you can just use make_scoped_ptr always now. > > And when you want to return or assign an empty scoped_ptr(), you can > now use nullptr directly. > > Also adds PRESUBMIT checks for: > - return scoped<T>(foo). This should be return make_scoped_ptr(foo). > - bar = scoped<T>(foo). This should be return bar = make_scoped_ptr(foo). > - return scoped<T>(). This should be return nullptr. > - bar = scoped<T>(). This should be return bar = nullptr. > > This also replaces p.reset() with p = nullptr; But it does not add a > PRESUBMIT check for that because there are things other than scoped_ptr > with a reset() function. > > R=enne@chromium.org > > Committed: https://crrev.com/7bb3dbede19d87f0338797756ffd738adc6bca08 > Cr-Commit-Position: refs/heads/master@{#297096} TBR=enne@chromium.org,jamesr@chromium.org,vmpstr@chromium.org,danakj@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/78d5331bcd375f8c8f0285d648dc30cc4f206367 Cr-Commit-Position: refs/heads/master@{#297106}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+621 lines, -546 lines) Patch
M cc/PRESUBMIT.py View 2 chunks +0 lines, -35 lines 0 comments Download
M cc/animation/animation_unittest.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M cc/animation/keyframed_animation_curve.cc View 9 chunks +22 lines, -22 lines 0 comments Download
M cc/animation/keyframed_animation_curve_unittest.cc View 1 chunk +4 lines, -1 line 0 comments Download
M cc/animation/layer_animation_controller_unittest.cc View 16 chunks +32 lines, -26 lines 0 comments Download
M cc/animation/scroll_offset_animation_curve.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M cc/animation/timing_function.cc View 1 chunk +10 lines, -5 lines 0 comments Download
M cc/base/math_util.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/base/region.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/base/scoped_ptr_vector.h View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/blink/web_animation_curve_common.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/blink/web_filter_animation_curve_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/blink/web_float_animation_curve_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/blink/web_transform_animation_curve_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/debug/micro_benchmark_controller.cc View 1 chunk +8 lines, -5 lines 0 comments Download
M cc/debug/micro_benchmark_controller_unittest.cc View 4 chunks +12 lines, -12 lines 0 comments Download
M cc/debug/picture_record_benchmark.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/debug/rasterize_and_record_benchmark.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/debug/rasterize_and_record_benchmark_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/debug/unittest_only_benchmark.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/input/top_controls_manager.cc View 1 chunk +3 lines, -1 line 0 comments Download
M cc/layers/content_layer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/layers/delegated_renderer_layer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/layers/delegated_renderer_layer_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/layers/delegated_renderer_layer_impl_unittest.cc View 7 chunks +15 lines, -14 lines 0 comments Download
M cc/layers/heads_up_display_layer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/layers/heads_up_display_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/heads_up_display_layer_impl_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/layers/io_surface_layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/io_surface_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/layer.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/layers/layer_impl.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M cc/layers/layer_impl_unittest.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M cc/layers/layer_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/layer_unittest.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M cc/layers/nine_patch_layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/nine_patch_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/painted_scrollbar_layer.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M cc/layers/painted_scrollbar_layer_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/layers/picture_image_layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/picture_image_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/picture_image_layer_impl_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M cc/layers/picture_layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/picture_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/picture_layer_impl_perftest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 9 chunks +18 lines, -15 lines 0 comments Download
M cc/layers/solid_color_layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/solid_color_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/solid_color_scrollbar_layer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/layers/solid_color_scrollbar_layer_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/layers/surface_layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/surface_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/texture_layer.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M cc/layers/texture_layer_impl.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M cc/layers/texture_layer_unittest.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M cc/layers/tiled_layer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/layers/tiled_layer_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/layers/tiled_layer_unittest.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M cc/layers/ui_resource_layer.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M cc/layers/ui_resource_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/video_layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/video_layer_impl.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M cc/output/bsp_tree.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/output/delegating_renderer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/output/gl_renderer.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M cc/output/gl_renderer_unittest.cc View 9 chunks +18 lines, -17 lines 0 comments Download
M cc/output/output_surface_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/output/renderer_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M cc/output/software_renderer.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M cc/output/software_renderer_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/quads/draw_polygon.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/quads/render_pass_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M cc/resources/bitmap_content_layer_updater.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/bitmap_skpicture_content_layer_updater.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/image_layer_updater.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/picture.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/prioritized_resource_unittest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M cc/resources/raster_worker_pool_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M cc/resources/resource_provider.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/resources/resource_provider_unittest.cc View 28 chunks +54 lines, -52 lines 0 comments Download
M cc/resources/task_graph_runner_perftest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/texture_mailbox_deleter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/tile_manager_perftest.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M cc/resources/tile_manager_unittest.cc View 5 chunks +6 lines, -5 lines 0 comments Download
M cc/resources/ui_resource_request.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/surfaces/surface_aggregator.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/animation_test_common.cc View 6 chunks +19 lines, -14 lines 0 comments Download
M cc/test/cc_test_suite.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/fake_content_layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/fake_content_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/fake_delegated_renderer_layer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/test/fake_delegated_renderer_layer_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/test/fake_layer_tree_host_client.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M cc/test/fake_output_surface.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/fake_picture_layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/fake_picture_layer_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/test/fake_tile_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/layer_test_common.h View 5 chunks +5 lines, -5 lines 0 comments Download
M cc/test/layer_test_common.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/test/layer_tree_pixel_test.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M cc/test/layer_tree_test.cc View 5 chunks +13 lines, -11 lines 0 comments Download
M cc/test/pixel_test.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M cc/test/render_pass_test_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/test/test_shared_bitmap_manager.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M cc/test/test_web_graphics_context_3d.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/test/tiled_layer_test_common.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 10 chunks +19 lines, -19 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 35 chunks +68 lines, -52 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 7 chunks +16 lines, -10 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_animation.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_context.cc View 10 chunks +12 lines, -12 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_copyrequest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_host_unittest_no_message_loop.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_scroll.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_impl.cc View 5 chunks +12 lines, -12 lines 0 comments Download
M cc/trees/layer_tree_impl_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M cc/trees/occlusion_tracker_perftest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M cc/trees/occlusion_tracker_unittest.cc View 3 chunks +13 lines, -5 lines 0 comments Download
M cc/trees/single_thread_proxy.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M cc/trees/thread_proxy.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M cc/trees/tree_synchronizer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/tree_synchronizer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
dcheng
Created Revert of cc: Remove use of PassAs() and constructor-casting with scoped_ptr.
6 years, 2 months ago (2014-09-27 07:31:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/608503005/1
6 years, 2 months ago (2014-09-27 07:32:09 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 9cc7c5f79c7b3b2909b8d64aa8e8614c5fb0e8d2
6 years, 2 months ago (2014-09-27 07:33:21 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-09-27 07:34:02 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/78d5331bcd375f8c8f0285d648dc30cc4f206367
Cr-Commit-Position: refs/heads/master@{#297106}

Powered by Google App Engine
This is Rietveld 408576698