cc/debug/rasterize_and_record_benchmark.cc - Issue 608503005: Revert of cc: Remove use of PassAs() and constructor-casting with scoped_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/debug/rasterize_and_record_benchmark.cc

Issue 608503005: Revert of cc: Remove use of PassAs() and constructor-casting with scoped_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/debug/rasterize_and_record_benchmark.cc

diff --git a/cc/debug/rasterize_and_record_benchmark.cc b/cc/debug/rasterize_and_record_benchmark.cc

index 9d1bfe66582cfc1bf544d9ead60d27d247108365..c2a47d022fdf3f18ba2380987e1c39d3d2d3fd82 100644

--- a/cc/debug/rasterize_and_record_benchmark.cc

+++ b/cc/debug/rasterize_and_record_benchmark.cc

@@ -80,12 +80,12 @@

results_->MergeDictionary(results);

- NotifyDone(results_.Pass());

+ NotifyDone(results_.PassAs<base::Value>());

}

scoped_ptr<MicroBenchmarkImpl> RasterizeAndRecordBenchmark::CreateBenchmarkImpl(

scoped_refptr<base::MessageLoopProxy> origin_loop) {

- return make_scoped_ptr(new RasterizeAndRecordBenchmarkImpl(

+ return scoped_ptr<MicroBenchmarkImpl>(new RasterizeAndRecordBenchmarkImpl(

origin_loop,

settings_.get(),

base::Bind(&RasterizeAndRecordBenchmark::RecordRasterResults,

« no previous file with comments | « cc/debug/picture_record_benchmark.cc ('k') | cc/debug/rasterize_and_record_benchmark_impl.cc » ('j') | no next file with comments »