Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Unified Diff: Source/platform/fonts/SimpleShaper.cpp

Issue 608413002: Change SimpleShaper::advance to take unsigned (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/fonts/SimpleShaper.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/fonts/SimpleShaper.cpp
diff --git a/Source/platform/fonts/SimpleShaper.cpp b/Source/platform/fonts/SimpleShaper.cpp
index 4a5605bcdfd143a21ee2563071ad4042db81caea..d493b78d65d20f678401b45c4b1e4aaf59ea204a 100644
--- a/Source/platform/fonts/SimpleShaper.cpp
+++ b/Source/platform/fonts/SimpleShaper.cpp
@@ -233,14 +233,14 @@ unsigned SimpleShaper::advanceInternal(TextIterator& textIterator, GlyphBuffer*
return consumedCharacters;
}
-unsigned SimpleShaper::advance(int offset, GlyphBuffer* glyphBuffer)
+unsigned SimpleShaper::advance(unsigned offset, GlyphBuffer* glyphBuffer)
{
- int length = m_run.length();
+ unsigned length = m_run.length();
if (offset > length)
offset = length;
- if (m_currentCharacter >= static_cast<unsigned>(offset))
+ if (m_currentCharacter >= offset)
return 0;
if (m_run.is8Bit()) {
« no previous file with comments | « Source/platform/fonts/SimpleShaper.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698