Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 608263002: gpu: Remove in-process GPU service support for CHROMIUM_image. (Closed)

Created:
6 years, 2 months ago by reveman
Modified:
6 years, 2 months ago
Reviewers:
boliu, piman
CC:
chromium-reviews, piman+watch_chromium.org, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

gpu: Remove in-process GPU service support for CHROMIUM_image. This also removes the android_webview GpuMemoryBuffer implementation. BUG=418553 Committed: https://crrev.com/ec103f0dcc3fc00f4e6659550120540d98b0aed8 Cr-Commit-Position: refs/heads/master@{#297224}

Patch Set 1 #

Total comments: 8

Patch Set 2 : more webview remove #

Patch Set 3 : fix typo #

Patch Set 4 : more build fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -506 lines) Patch
M android_webview/android_webview.gyp View 1 1 chunk +0 lines, -2 lines 0 comments Download
M android_webview/browser/browser_view_renderer.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M android_webview/browser/browser_view_renderer.cc View 1 2 3 2 chunks +6 lines, -21 lines 0 comments Download
D android_webview/browser/gpu_memory_buffer_factory_impl.h View 1 chunk +0 lines, -41 lines 0 comments Download
D android_webview/browser/gpu_memory_buffer_factory_impl.cc View 1 chunk +0 lines, -124 lines 0 comments Download
M android_webview/lib/main/aw_main_delegate.h View 2 chunks +0 lines, -2 lines 0 comments Download
M android_webview/lib/main/aw_main_delegate.cc View 1 2 3 3 chunks +3 lines, -16 lines 0 comments Download
M android_webview/native/aw_contents.cc View 1 2 chunks +0 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.h View 5 chunks +0 lines, -34 lines 0 comments Download
M gpu/command_buffer/service/in_process_command_buffer.cc View 4 chunks +5 lines, -81 lines 0 comments Download
M ui/gl/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/gl/gl.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
D ui/gl/gl_image_android_native_buffer.h View 1 chunk +0 lines, -45 lines 0 comments Download
D ui/gl/gl_image_android_native_buffer.cc View 1 chunk +0 lines, -132 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
reveman
6 years, 2 months ago (2014-09-29 14:58:25 UTC) #2
boliu
lgtm
6 years, 2 months ago (2014-09-29 15:10:08 UTC) #3
boliu
still need a bunch of compile fixes on android https://codereview.chromium.org/608263002/diff/1/android_webview/browser/gpu_memory_buffer_factory_impl.cc File android_webview/browser/gpu_memory_buffer_factory_impl.cc (left): https://codereview.chromium.org/608263002/diff/1/android_webview/browser/gpu_memory_buffer_factory_impl.cc#oldcode1 android_webview/browser/gpu_memory_buffer_factory_impl.cc:1: ...
6 years, 2 months ago (2014-09-29 15:47:18 UTC) #4
reveman
sorry, I was bit quick to upload that patch. I think this should be good ...
6 years, 2 months ago (2014-09-29 18:32:09 UTC) #5
piman
lgtm
6 years, 2 months ago (2014-09-29 18:33:01 UTC) #6
boliu
lgtm
6 years, 2 months ago (2014-09-29 18:34:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/608263002/60001
6 years, 2 months ago (2014-09-29 18:34:55 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001) as cbdcc84868b1582fc06f74bb2636546c610311b7
6 years, 2 months ago (2014-09-29 19:12:39 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 19:13:29 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/ec103f0dcc3fc00f4e6659550120540d98b0aed8
Cr-Commit-Position: refs/heads/master@{#297224}

Powered by Google App Engine
This is Rietveld 408576698