src/gpu/effects/GrConfigConversionEffect.h - Issue 608253002: Add isSingleComponent bool to getConstantColorComponent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/effects/GrConfigConversionEffect.h

Issue 608253002: Add isSingleComponent bool to getConstantColorComponent (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Update comment and nits Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/effects/GrConfigConversionEffect.h

diff --git a/src/gpu/effects/GrConfigConversionEffect.h b/src/gpu/effects/GrConfigConversionEffect.h

index 765e49b45ba05995fb765133c8a571e280071eb3..31d5b4d0d1c6355c89c3bbc4fbd38c628d546c10 100644

--- a/src/gpu/effects/GrConfigConversionEffect.h

+++ b/src/gpu/effects/GrConfigConversionEffect.h

@@ -43,8 +43,6 @@ public:

virtual const GrBackendFragmentProcessorFactory& getFactory() const SK_OVERRIDE;

- virtual void getConstantColorComponents(GrColor* color, uint32_t* validFlags) const SK_OVERRIDE;

bool swapsRedAndBlue() const { return fSwapRedAndBlue; }

PMConversion pmConversion() const { return fPMConversion; }

@@ -65,6 +63,8 @@ private:

virtual bool onIsEqual(const GrProcessor&) const SK_OVERRIDE;

+ virtual void onComputeInvarientOutput(InvarientOutput* invarientOutput) const SK_OVERRIDE;

bool fSwapRedAndBlue;

PMConversion fPMConversion;