src/gpu/effects/GrBicubicEffect.cpp - Issue 608253002: Add isSingleComponent bool to getConstantColorComponent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/effects/GrBicubicEffect.cpp

Issue 608253002: Add isSingleComponent bool to getConstantColorComponent (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Update comment and nits Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/effects/GrBicubicEffect.cpp

diff --git a/src/gpu/effects/GrBicubicEffect.cpp b/src/gpu/effects/GrBicubicEffect.cpp

index d73e604b04530fd062d91cd03aa6dce894bc8b3c..fef58e358f2204a7d6c5b4dda92c72e8bf6d1ecc 100644

--- a/src/gpu/effects/GrBicubicEffect.cpp

+++ b/src/gpu/effects/GrBicubicEffect.cpp

@@ -169,9 +169,10 @@ bool GrBicubicEffect::onIsEqual(const GrProcessor& sBase) const {

fDomain == s.fDomain;

}

-void GrBicubicEffect::getConstantColorComponents(GrColor* color, uint32_t* validFlags) const {

+void GrBicubicEffect::onComputeInvarientOutput(InvarientOutput* invarientOutput) const {

// FIXME: Perhaps we can do better.

- *validFlags = 0;

+ invarientOutput->validFlags = 0;

+ invarientOutput->isSingleComponent = false;

return;

}