Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: chrome/browser/policy/schema_registry_unittest.cc

Issue 60823003: Introduced a ForwardingPolicyProvider. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase, fixes Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/policy/schema_registry_unittest.cc
diff --git a/chrome/browser/policy/schema_registry_unittest.cc b/chrome/browser/policy/schema_registry_unittest.cc
index 62bed9e6b490e9c6c66f7773c7c80d123b4b6a87..29e2a91254d499303d61f0680b3341830e19af74 100644
--- a/chrome/browser/policy/schema_registry_unittest.cc
+++ b/chrome/browser/policy/schema_registry_unittest.cc
@@ -45,6 +45,7 @@ class MockSchemaRegistryObserver : public SchemaRegistry::Observer {
virtual ~MockSchemaRegistryObserver() {}
MOCK_METHOD1(OnSchemaRegistryUpdated, void(bool));
+ MOCK_METHOD0(OnSchemaRegistryReady, void());
};
} // namespace
@@ -100,6 +101,22 @@ TEST(SchemaRegistryTest, Notifications) {
EXPECT_FALSE(registry.HasObservers());
}
+TEST(SchemaRegistryTest, IsReady) {
+ SchemaRegistry registry;
+ EXPECT_FALSE(registry.IsReady());
+ registry.SetReady(POLICY_DOMAIN_CHROME);
+#if defined(ENABLE_EXTENSIONS)
+ EXPECT_FALSE(registry.IsReady());
+ registry.SetReady(POLICY_DOMAIN_EXTENSIONS);
+ EXPECT_TRUE(registry.IsReady());
+ registry.SetReady(POLICY_DOMAIN_EXTENSIONS);
bartfab (slow) 2013/11/11 14:40:08 Nit 1: It would be useful to have an observer in t
Joao da Silva 2013/11/12 15:26:33 Done.
+#endif
+ EXPECT_TRUE(registry.IsReady());
+
+ CombinedSchemaRegistry combined;
+ EXPECT_TRUE(combined.IsReady());
+}
+
TEST(SchemaRegistryTest, Combined) {
std::string error;
Schema schema = Schema::Parse(kTestSchema, &error);

Powered by Google App Engine
This is Rietveld 408576698