Introduced a ForwardingPolicyProvider.

chrome/browser/policy/schema_registry_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/policy/schema_registry.h"
 
 #include "components/policy/core/common/policy_namespace.h"
 #include "components/policy/core/common/schema.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 27 matching lines @@
     "    }"
     "  }"
     "}";
 
 class MockSchemaRegistryObserver : public SchemaRegistry::Observer {
  public:
   MockSchemaRegistryObserver() {}
   virtual ~MockSchemaRegistryObserver() {}
 
   MOCK_METHOD1(OnSchemaRegistryUpdated, void(bool));
+  MOCK_METHOD0(OnSchemaRegistryReady, void());
 };
 
 }  // namespace
 
 TEST(SchemaRegistryTest, Notifications) {
   std::string error;
   Schema schema = Schema::Parse(kTestSchema, &error);
   ASSERT_TRUE(schema.valid()) << error;
 
   MockSchemaRegistryObserver observer;
@@ skipping 35 matching lines @@
   components["def"] = schema;
   components["xyz"] = schema;
   EXPECT_CALL(observer, OnSchemaRegistryUpdated(true));
   registry.RegisterComponents(POLICY_DOMAIN_EXTENSIONS, components);
   Mock::VerifyAndClearExpectations(&observer);
 
   registry.RemoveObserver(&observer);
   EXPECT_FALSE(registry.HasObservers());
 }
 
+TEST(SchemaRegistryTest, IsReady) {
+  SchemaRegistry registry;
+  EXPECT_FALSE(registry.IsReady());
+  registry.SetReady(POLICY_DOMAIN_CHROME);
+#if defined(ENABLE_EXTENSIONS)
+  EXPECT_FALSE(registry.IsReady());
+  registry.SetReady(POLICY_DOMAIN_EXTENSIONS);
+  EXPECT_TRUE(registry.IsReady());
+  registry.SetReady(POLICY_DOMAIN_EXTENSIONS);

[bartfab (slow), 2013/11/11 14:40:08]

Nit 1: It would be useful to have an observer in this test, verifying not only
that IsReady() does not misbehave when the same domain becomes ready but also
OnSchemaRegistryReady() does not fire too often.

Nit 2: Why not use POLICY_DOMAIN_CHROME as the domain that you mark as ready
twice? That way, marking a component as ready twice would get tested even if
ENABLE_EXTENSIONS is not defined.

[Joao da Silva, 2013/11/12 15:26:33]

Done.

+#endif
+  EXPECT_TRUE(registry.IsReady());
+
+  CombinedSchemaRegistry combined;
+  EXPECT_TRUE(combined.IsReady());
+}
+
 TEST(SchemaRegistryTest, Combined) {
   std::string error;
   Schema schema = Schema::Parse(kTestSchema, &error);
   ASSERT_TRUE(schema.valid()) << error;
 
   MockSchemaRegistryObserver observer;
   SchemaRegistry registry1;
   SchemaRegistry registry2;
   CombinedSchemaRegistry combined;
   combined.AddObserver(&observer);
@@ skipping 92 matching lines @@
   Mock::VerifyAndClearExpectations(&observer);
 
   EXPECT_CALL(observer, OnSchemaRegistryUpdated(false));
   combined.Untrack(&registry2);
   Mock::VerifyAndClearExpectations(&observer);
 
   combined.RemoveObserver(&observer);
 }
 
 }  // namespace policy