Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issue 608133002: [SyncFS] Use nullptr for scoped_ptr initialization (Closed)

Created:
6 years, 2 months ago by tzik
Modified:
6 years, 2 months ago
Reviewers:
peria
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@nullptr
Project:
chromium
Visibility:
Public.

Description

[SyncFS] Use nullptr for scoped_ptr initialization BUG=None Committed: https://crrev.com/af111ac4b1deff9861bef0dd6a76004b0dae265e Cr-Commit-Position: refs/heads/master@{#297233}

Patch Set 1 #

Total comments: 8

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -23 lines) Patch
M chrome/browser/sync_file_system/drive_backend/callback_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/callback_tracker_internal.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_backend_sync_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/fake_sync_worker.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_engine_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_task_manager.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_task_token.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/sync_worker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/mock_remote_file_sync_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/sync_file_system_service.cc View 1 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
tzik
PTL
6 years, 2 months ago (2014-09-29 02:03:36 UTC) #2
peria
lgtm with nits https://codereview.chromium.org/608133002/diff/1/chrome/browser/sync_file_system/drive_backend/sync_task_manager.cc File chrome/browser/sync_file_system/drive_backend/sync_task_manager.cc (right): https://codereview.chromium.org/608133002/diff/1/chrome/browser/sync_file_system/drive_backend/sync_task_manager.cc#newcode294 chrome/browser/sync_file_system/drive_backend/sync_task_manager.cc:294: MaybeStartNextForegroundTask(nullptr /* token */); nit: remove ...
6 years, 2 months ago (2014-09-29 02:32:27 UTC) #3
tzik
https://codereview.chromium.org/608133002/diff/1/chrome/browser/sync_file_system/drive_backend/sync_task_manager.cc File chrome/browser/sync_file_system/drive_backend/sync_task_manager.cc (right): https://codereview.chromium.org/608133002/diff/1/chrome/browser/sync_file_system/drive_backend/sync_task_manager.cc#newcode294 chrome/browser/sync_file_system/drive_backend/sync_task_manager.cc:294: MaybeStartNextForegroundTask(nullptr /* token */); On 2014/09/29 02:32:27, peria wrote: ...
6 years, 2 months ago (2014-09-29 18:34:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/608133002/20001
6 years, 2 months ago (2014-09-29 18:35:52 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 0cb403c4ccaff7c33edc67826351bdf61503f2ce
6 years, 2 months ago (2014-09-29 19:35:28 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 19:36:46 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/af111ac4b1deff9861bef0dd6a76004b0dae265e
Cr-Commit-Position: refs/heads/master@{#297233}

Powered by Google App Engine
This is Rietveld 408576698