chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc - Issue 608133002: [SyncFS] Use nullptr for scoped_ptr initialization

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc

Issue 608133002: [SyncFS] Use nullptr for scoped_ptr initialization (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@nullptr

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/sync_file_system/drive_backend/metadata_database.cc ('k') | chrome/browser/sync_file_system/drive_backend/sync_engine.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc

diff --git a/chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc b/chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc

index 6df37833de9811460b5baca6337f6591e10bc8dc..8d352328505f0d164930387784628d54b96b7103 100644

--- a/chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc

+++ b/chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc

@@ -254,7 +254,7 @@ MetadataDatabaseIndexOnDisk::Create(LevelDBWrapper* db) {

scoped_ptr<ServiceMetadata> service_metadata = InitializeServiceMetadata(db);

if (!service_metadata)

- return scoped_ptr<MetadataDatabaseIndexOnDisk>();

+ return nullptr;

PutVersionToDB(kDatabaseOnDiskVersion, db);

RemoveUnreachableItems(db, service_metadata->sync_root_tracker_id());