Issue 60803004: mac: Turn on -Wunused-functions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 60803004: mac: Turn on -Wunused-functions. (Closed)

Created:
7 years, 1 month ago by Nico

Modified:
7 years, 1 month ago

Reviewers:
hans

CC:
chromium-reviews, skanuj+watch_chromium.org, tzik, dhollowa+watch_chromium.org, dougw+watch_chromium.org, browser-components-watch_chromium.org, chrome-speed-team+watch_google.com, joi+watch-content_chromium.org, kinuko+watch, Ilya Sherman, tim+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, melevin+watch_chromium.org, benquan, kkania, jam, dominich, marja+watch_chromium.org, lambroslambrou+watch_chromium.org, darin-cc_chromium.org, rouslan+autofillwatch_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, amit, dyu1, dcaiafa+watch_chromium.org, wez+watch_chromium.org, sanjeevr, haitaol+watch_chromium.org, jfweitz+watch_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, estade+watch_chromium.org, sergeyu+watch_chromium.org, Jered, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, donnd+watch_chromium.org, frankf, garykac+watch_chromium.org, dsinclair+watch_chromium.org, David Black, Dane Wallinga, samarth+watch_chromium.org, nhiroki+watch_chromium.org, kmadhusu+watch_chromium.org, alexeypa+watch_chromium.org, rsimha+watch_chromium.org, oshima

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -9 lines)			Patch
	M	build/common.gypi	View	1 2 3 4	3 chunks	+6 lines, -4 lines	0 comments	Download
	M	tools/gn/target.cc	View	1 2 3 4 5 6	1 chunk	+0 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Nico

Yesterday, things built with this. It's possible people checked in more dead code over the ...

7 years, 1 month ago (2013-11-09 01:18:52 UTC) #1

hans

On 2013/11/09 01:18:52, Nico (ooo until Nov 12) wrote: > Yesterday, things built with this. ...

7 years, 1 month ago (2013-11-09 01:22:57 UTC) #2

Nico

7 years, 1 month ago (2013-11-09 04:18:26 UTC) #3

Message was sent while issue was closed.

Committed patchset #7 manually as r234081 (presubmit successful).

Expand Messages | Collapse Messages

Issue 60803004: mac: Turn on -Wunused-functions. (Closed)

Description

Patch Set 1 #

Patch Set 2 : mac: Turn on -Wunused-functions. #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : rebase #

Patch Set 6 : rebase #

Patch Set 7 : gn #

Messages