Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: build/common.gypi

Issue 60803004: mac: Turn on -Wunused-functions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: gn Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/gn/target.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 5eafc333bfaa8bc10e9c7a215adfc778278191cd..bf4a6808eddd32424e3447e67f817782d23f32a5 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -3215,7 +3215,7 @@
# Don't die on dtoa code that uses a char as an array index.
'-Wno-char-subscripts',
- # Clang spots more unused functions.
+ # Clang spots more unused functions. TODO remove, crbug.com/315884
'-Wno-unused-function',
# Warns on switches on enums that cover all enum values but
@@ -3930,8 +3930,10 @@
# This is required solely for base/third_party/dmg_fp/dtoa.cc.
'-Wno-char-subscripts',
- # Clang spots more unused functions.
- '-Wno-unused-function',
+ # TODO(thakis): This used to be implied by -Wno-unused-function,
+ # which we no longer use. Check if it makes sense to remove
+ # this as well. http://crbug.com/316352
+ '-Wno-unneeded-internal-declaration',
# Warns on switches on enums that cover all enum values but
# also contain a default: branch. Chrome is full of that.
@@ -4219,7 +4221,7 @@
# Don't die on dtoa code that uses a char as an array index.
# This is required solely for base/third_party/dmg_fp/dtoa.cc.
'-Wno-char-subscripts',
- # Clang spots more unused functions.
+ # Clang spots more unused functions. TODO: remove, crbug.com/315884
'-Wno-unused-function',
# Match OS X clang C++11 warning settings.
'-Wno-c++11-narrowing',
« no previous file with comments | « no previous file | tools/gn/target.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698