Chromecast: Android devtools needs remote frontend URL.

Chromecast: Android devtools needs remote frontend URL.

If not, this code blocks it from loading:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/webui/devtools_ui.cc&sq=package:chromium&type=cs&rcl=1411534708&l=343

R=dgozman@chromium.org,lcwu@chromium.org
BUG=400876
Committed: https://crrev.com/f4c1193e921319773384f5ee4f5f16967e468341
Cr-Commit-Position: refs/heads/master@{#297433}

[dgozman, 2014-09-27 07:28:53]

This isn't a right fix: if you bundle frontend, you should not pass appspot url.
Instead, the problem is either in DevToolsHttpHandler (we serve the wrong url)
or DevToolsUI (we use it incorrectly).

Is there an instruction on how to build the android chromecast product? I will
take a look into this issue.

[gunsch, 2014-09-29 16:05:03]

On 2014/09/27 07:28:53, dgozman wrote:
> This isn't a right fix: if you bundle frontend, you should not pass appspot
url.
> Instead, the problem is either in DevToolsHttpHandler (we serve the wrong url)
> or DevToolsUI (we use it incorrectly).
> 
> Is there an instruction on how to build the android chromecast product? I will
> take a look into this issue.

Sent you some internal links, as well as instructions to build from public
Chromium. Both exhibit the same issue. Thanks for taking a look.

[dgozman, 2014-09-30 13:14:47]

After looking closely, I think the issue is that we didn't bother supporting
bundled frontend in wired debugging scenario, since there were no such products.
Filed a crbug.com/418970 for that.

This means android cast should use external frontend until the issue is fixed.
Sorry for confusion.
lgtm, but please fix BundlesFrontendResources as well.

https://codereview.chromium.org/607973004/diff/1/chromecast/shell/browser/dev...
File chromecast/shell/browser/devtools/remote_debugging_server.cc (right):

https://codereview.chromium.org/607973004/diff/1/chromecast/shell/browser/dev...
chromecast/shell/browser/devtools/remote_debugging_server.cc:147:
GetFrontendUrl(),
Please, also change CastDevToolsDelegate::BundlesFrontendResources.
#if defined(OS_ANDROID)
  return false;
#else
  return true;
#endif  // defined(OS_ANDROID)

[gunsch, 2014-09-30 15:53:30]

https://codereview.chromium.org/607973004/diff/1/chromecast/shell/browser/dev...
File chromecast/shell/browser/devtools/remote_debugging_server.cc (right):

https://codereview.chromium.org/607973004/diff/1/chromecast/shell/browser/dev...
chromecast/shell/browser/devtools/remote_debugging_server.cc:147:
GetFrontendUrl(),
On 2014/09/30 13:14:46, dgozman wrote:
> Please, also change CastDevToolsDelegate::BundlesFrontendResources.
> #if defined(OS_ANDROID)
>   return false;
> #else
>   return true;
> #endif  // defined(OS_ANDROID)

Done.

[gunsch, 2014-09-30 15:53:41]

The CQ bit was checked by gunsch@chromium.org

[commit-bot: I haz the power, 2014-09-30 15:54:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/607973004/20001

[commit-bot: I haz the power, 2014-09-30 16:26:19]

Committed patchset #2 (id:20001) as 1436488a597199b6a55b8582c29cb0f0e0181c4d

[commit-bot: I haz the power, 2014-09-30 16:27:15]

Patchset 2 (id:??) landed as
https://crrev.com/f4c1193e921319773384f5ee4f5f16967e468341
Cr-Commit-Position: refs/heads/master@{#297433}