Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(493)

Side by Side Diff: chromecast/shell/browser/devtools/cast_dev_tools_delegate.cc

Issue 607973004: Chromecast: Android devtools needs remote frontend URL. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: report frontend resources not bundled Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chromecast/shell/browser/devtools/remote_debugging_server.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chromecast/shell/browser/devtools/cast_dev_tools_delegate.h" 5 #include "chromecast/shell/browser/devtools/cast_dev_tools_delegate.h"
6 6
7 #include "base/files/file_path.h" 7 #include "base/files/file_path.h"
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "content/public/browser/devtools_agent_host.h" 10 #include "content/public/browser/devtools_agent_host.h"
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 94
95 // CastDevToolsDelegate ----------------------------------------------------- 95 // CastDevToolsDelegate -----------------------------------------------------
96 96
97 CastDevToolsDelegate::CastDevToolsDelegate() { 97 CastDevToolsDelegate::CastDevToolsDelegate() {
98 } 98 }
99 99
100 CastDevToolsDelegate::~CastDevToolsDelegate() { 100 CastDevToolsDelegate::~CastDevToolsDelegate() {
101 } 101 }
102 102
103 std::string CastDevToolsDelegate::GetDiscoveryPageHTML() { 103 std::string CastDevToolsDelegate::GetDiscoveryPageHTML() {
104 #if defined(OS_ANDROID)
105 return std::string();
106 #else
104 return ResourceBundle::GetSharedInstance().GetRawDataResource( 107 return ResourceBundle::GetSharedInstance().GetRawDataResource(
105 IDR_CAST_SHELL_DEVTOOLS_DISCOVERY_PAGE).as_string(); 108 IDR_CAST_SHELL_DEVTOOLS_DISCOVERY_PAGE).as_string();
109 #endif // defined(OS_ANDROID)
106 } 110 }
107 111
108 bool CastDevToolsDelegate::BundlesFrontendResources() { 112 bool CastDevToolsDelegate::BundlesFrontendResources() {
113 #if defined(OS_ANDROID)
114 return false;
115 #else
109 return true; 116 return true;
117 #endif // defined(OS_ANDROID)
110 } 118 }
111 119
112 base::FilePath CastDevToolsDelegate::GetDebugFrontendDir() { 120 base::FilePath CastDevToolsDelegate::GetDebugFrontendDir() {
113 return base::FilePath(); 121 return base::FilePath();
114 } 122 }
115 123
116 scoped_ptr<net::StreamListenSocket> 124 scoped_ptr<net::StreamListenSocket>
117 CastDevToolsDelegate::CreateSocketForTethering( 125 CastDevToolsDelegate::CreateSocketForTethering(
118 net::StreamListenSocket::Delegate* delegate, 126 net::StreamListenSocket::Delegate* delegate,
119 std::string* name) { 127 std::string* name) {
(...skipping 30 matching lines...) Expand all
150 content::DevToolsAgentHost::GetOrCreateAll(); 158 content::DevToolsAgentHost::GetOrCreateAll();
151 for (content::DevToolsAgentHost::List::iterator it = agents.begin(); 159 for (content::DevToolsAgentHost::List::iterator it = agents.begin();
152 it != agents.end(); ++it) { 160 it != agents.end(); ++it) {
153 targets.push_back(new Target(*it)); 161 targets.push_back(new Target(*it));
154 } 162 }
155 callback.Run(targets); 163 callback.Run(targets);
156 } 164 }
157 165
158 } // namespace shell 166 } // namespace shell
159 } // namespace chromecast 167 } // namespace chromecast
OLDNEW
« no previous file with comments | « no previous file | chromecast/shell/browser/devtools/remote_debugging_server.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698