Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 607893002: DevTools: Avoid build errors when dynamic module and application names clash (Closed)

Created:
6 years, 2 months ago by apavlov
Modified:
6 years, 2 months ago
Reviewers:
dgozman, pfeldman, yurys
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: Avoid build errors when dynamic module and application names clash This is a provisional fix that should let developers name dynamically loaded modules the same as existing applications. Drive-by: - Clean up devtools.gypi - Stop generating obsolete code when concatenating workers R=dgozman, pfeldman, yurys Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182769

Patch Set 1 #

Patch Set 2 : Fix BUILD.gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -72 lines) Patch
M Source/devtools/BUILD.gn View 1 3 chunks +26 lines, -24 lines 0 comments Download
M Source/devtools/devtools.gyp View 19 chunks +36 lines, -36 lines 0 comments Download
M Source/devtools/devtools.gypi View 4 chunks +2 lines, -2 lines 0 comments Download
M Source/devtools/front_end/Runtime.js View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/devtools/scripts/concatenate_application_code.py View 2 chunks +1 line, -7 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
apavlov
6 years, 2 months ago (2014-09-26 13:07:03 UTC) #1
dgozman
lgtm
6 years, 2 months ago (2014-09-26 13:23:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/607893002/20001
6 years, 2 months ago (2014-09-26 13:25:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/607893002/20001
6 years, 2 months ago (2014-09-26 13:37:00 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 182769
6 years, 2 months ago (2014-09-26 14:33:24 UTC) #8
apavlov
6 years, 2 months ago (2014-09-26 16:38:24 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/607113002/ by apavlov@chromium.org.

The reason for reverting is: This patch makes the "build_applications" target
always dirty..

Powered by Google App Engine
This is Rietveld 408576698