Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 607853003: Roll src/third_party/skia b5fae93:c13bc57 (manual roll) (Closed)

Created:
6 years, 2 months ago by f(malita)
Modified:
6 years, 2 months ago
CC:
chromium-reviews, robertphillips
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Roll src/third_party/skia b5fae93:c13bc57 (manual roll) Summary of changes available at: https://chromium.googlesource.com/skia/+log/b5fae93..c13bc57 This roll includes SkDevice::drawPosText API changes for GatherPixelRefDevice and VectorPlatformDeviceEmf, needed after https://codereview.chromium.org/605533002. CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg TBR=robertphillips@google.com Committed: https://crrev.com/7a643ed58259686084c51b426820bcaaa0cc3ec5 Cr-Commit-Position: refs/heads/master@{#297168}

Patch Set 1 #

Patch Set 2 : Win emf fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -22 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M skia/ext/pixel_ref_utils.cc View 2 chunks +6 lines, -14 lines 0 comments Download
M skia/ext/vector_platform_device_emf_win.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M skia/ext/vector_platform_device_emf_win.cc View 1 3 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/607853003/1
6 years, 2 months ago (2014-09-26 15:01:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/607853003/20001
6 years, 2 months ago (2014-09-26 15:36:34 UTC) #5
f(malita)
This looks good to go. Feel free to CQ when the roll gates open.
6 years, 2 months ago (2014-09-26 17:48:30 UTC) #9
robertphillips
lgtm
6 years, 2 months ago (2014-09-29 14:03:55 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/607853003/20001
6 years, 2 months ago (2014-09-29 14:04:44 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 12e062a5fe547be533f29d3ea15cea31825bc836
6 years, 2 months ago (2014-09-29 14:05:28 UTC) #14
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 14:06:19 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7a643ed58259686084c51b426820bcaaa0cc3ec5
Cr-Commit-Position: refs/heads/master@{#297168}

Powered by Google App Engine
This is Rietveld 408576698