Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 607803003: Fix the WebKit Android bot failures. (Closed)

Created:
6 years, 2 months ago by Fabrice (no longer in Chrome)
Modified:
6 years, 2 months ago
Reviewers:
cmp, tfarina, ppi, Dirk Pranke
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix the WebKit Android bot failures. This is a temporary workaround to make the bot green. Currently it fails with: Usage: lint-test-expectations [options] lint-test-expectations: error: no such option: --target TBR=cmp@chromium.org,dpranke@chromium.org,tfarina@chromium.org NOTREECHECKS=true NOTRY=true BUG=338338 Committed: https://crrev.com/7b06b610cdccf93eb7b02cbe5551853e5781f8c7 Cr-Commit-Position: refs/heads/master@{#296912}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M build/android/buildbot/bb_device_steps.py View 2 chunks +3 lines, -3 lines 1 comment Download

Messages

Total messages: 9 (2 generated)
Fabrice (no longer in Chrome)
6 years, 2 months ago (2014-09-26 09:43:16 UTC) #2
Fabrice (no longer in Chrome)
Sample failure: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/20578/steps/webkit_lint/logs/stdio
6 years, 2 months ago (2014-09-26 09:47:28 UTC) #3
ppi
rs lgtm
6 years, 2 months ago (2014-09-26 09:49:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/607803003/1
6 years, 2 months ago (2014-09-26 09:50:38 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 195e7b3f5392d6f2c735dc75ddc9e9868ec0a2c1
6 years, 2 months ago (2014-09-26 09:50:59 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7b06b610cdccf93eb7b02cbe5551853e5781f8c7 Cr-Commit-Position: refs/heads/master@{#296912}
6 years, 2 months ago (2014-09-26 09:51:28 UTC) #8
Dirk Pranke
6 years, 2 months ago (2014-09-26 20:36:17 UTC) #9
Message was sent while issue was closed.
https://codereview.chromium.org/607803003/diff/1/build/android/buildbot/bb_de...
File build/android/buildbot/bb_device_steps.py (right):

https://codereview.chromium.org/607803003/diff/1/build/android/buildbot/bb_de...
build/android/buildbot/bb_device_steps.py:291: '--android'])
We shouldn't actually need either ['--target', target] or ['--android'].
lint-test-expectations by default lints all of the configurations and is fast.

I'll post another CL to clean things up.

Powered by Google App Engine
This is Rietveld 408576698