Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1073)

Unified Diff: build/android/buildbot/bb_device_steps.py

Issue 607803003: Fix the WebKit Android bot failures. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/buildbot/bb_device_steps.py
diff --git a/build/android/buildbot/bb_device_steps.py b/build/android/buildbot/bb_device_steps.py
index d4e0fae021d3bae52a732d1074e5c4ee48325ebf..7be526e2e5b21bb5ebd0f8a1ee5d93153368b63a 100755
--- a/build/android/buildbot/bb_device_steps.py
+++ b/build/android/buildbot/bb_device_steps.py
@@ -284,11 +284,11 @@ def RunInstrumentationSuite(options, test, flunk_on_failure=True,
flunk_on_failure=flunk_on_failure)
-def RunWebkitLint(target):
+def RunWebkitLint():
"""Lint WebKit's TestExpectation files."""
bb_annotations.PrintNamedStep('webkit_lint')
RunCmd([SrcPath(os.path.join(BK_SCRIPTS_DIR, 'lint-test-expectations')),
- '--target', target])
+ '--android'])
Dirk Pranke 2014/09/26 20:36:17 We shouldn't actually need either ['--target', tar
def RunWebkitLayoutTests(options):
@@ -494,7 +494,7 @@ def RunInstrumentationTests(options):
def RunWebkitTests(options):
RunTestSuites(options, ['webkit_unit_tests', 'blink_heap_unittests'])
- RunWebkitLint(options.target)
+ RunWebkitLint()
def RunGPUTests(options):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698