Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 607733002: [telemetry] Detect and correct overflow in Intel energy MSRs. (Closed)

Created:
6 years, 2 months ago by dtu
Modified:
6 years, 2 months ago
Reviewers:
tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org, sullivan, Lei Zhang
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[telemetry] Detect and correct overflow in Intel energy MSRs. Failure seen here: http://build.chromium.org/p/chromium.perf/builders/Win%207%20Perf%20%281%29/builds/52 AssertionError: Negative energy consumption. (Starting energy was 65522.6123962.) BUG=336556, 336558 TEST=None. R=tonyg Committed: https://crrev.com/da1f537d23c875d49c73731b0880c67a32d27b09 Cr-Commit-Position: refs/heads/master@{#296880}

Patch Set 1 #

Patch Set 2 : Add start and length parameters to ReadMsr. #

Total comments: 2

Patch Set 3 : Docstring. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -13 lines) Patch
M tools/telemetry/telemetry/core/platform/linux_platform_backend.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/platform_backend.py View 1 2 1 chunk +7 lines, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/power_monitor/msr_power_monitor.py View 1 2 chunks +8 lines, -8 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/win_platform_backend.py View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
dtu
6 years, 2 months ago (2014-09-26 00:33:20 UTC) #1
tonyg
lgtm Sad that we don't have tests here. But I'm not sure what to suggest. ...
6 years, 2 months ago (2014-09-26 00:37:23 UTC) #2
dtu
https://codereview.chromium.org/607733002/diff/20001/tools/telemetry/telemetry/core/platform/platform_backend.py File tools/telemetry/telemetry/core/platform/platform_backend.py (right): https://codereview.chromium.org/607733002/diff/20001/tools/telemetry/telemetry/core/platform/platform_backend.py#newcode229 tools/telemetry/telemetry/core/platform/platform_backend.py:229: def ReadMsr(self, msr_number, start=0, length=64): On 2014/09/26 00:37:23, tonyg ...
6 years, 2 months ago (2014-09-26 00:59:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/607733002/40001
6 years, 2 months ago (2014-09-26 01:01:49 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001) as c25de3e6e775cef9be5647bacb6203cfd67baec9
6 years, 2 months ago (2014-09-26 04:12:24 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 04:13:12 UTC) #7
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/da1f537d23c875d49c73731b0880c67a32d27b09
Cr-Commit-Position: refs/heads/master@{#296880}

Powered by Google App Engine
This is Rietveld 408576698