Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Unified Diff: tools/telemetry/telemetry/core/platform/win_platform_backend.py

Issue 607733002: [telemetry] Detect and correct overflow in Intel energy MSRs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Docstring. Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/telemetry/telemetry/core/platform/power_monitor/msr_power_monitor.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/core/platform/win_platform_backend.py
diff --git a/tools/telemetry/telemetry/core/platform/win_platform_backend.py b/tools/telemetry/telemetry/core/platform/win_platform_backend.py
index 11e3195f43f3048826111024164f7f3c6fad9ef6..2ee894ecdc8f85bf62d724cf893d92241ef13cfb 100644
--- a/tools/telemetry/telemetry/core/platform/win_platform_backend.py
+++ b/tools/telemetry/telemetry/core/platform/win_platform_backend.py
@@ -346,7 +346,7 @@ class WinPlatformBackend(desktop_platform_backend.DesktopPlatformBackend):
self.CloseMsrServer()
atexit.register(TerminateProcess, self._msr_server_handle)
- def ReadMsr(self, msr_number):
+ def ReadMsr(self, msr_number, start=0, length=64):
self._StartMsrServerIfNeeded()
if not self._msr_server_handle:
raise OSError('Unable to start MSR server.')
@@ -357,4 +357,4 @@ class WinPlatformBackend(desktop_platform_backend.DesktopPlatformBackend):
response = sock.recv(8)
finally:
sock.close()
- return struct.unpack('Q', response)[0]
+ return struct.unpack('Q', response)[0] >> start & ((1 << length) - 1)
« no previous file with comments | « tools/telemetry/telemetry/core/platform/power_monitor/msr_power_monitor.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698