Replace hard-coded stack frame size literals with StandardFrameConstants::kFixedFrameSizeFromFp

Replace hard-coded stack frame size literals with StandardFrameConstants::kFixedFrameSizeFromFp

R=ulan@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=17925

[rmcilroy, 2013-11-19 16:10:53]

Ulan, could you please take a look.

Background of this CL is that during the OOL constant pool work I have spent
many hours tracking down all the constnat literals which need to be changed if
changing the stack frame size.  After this CL, only the kFixedFrameSizeFromFp
constant should need to be changed.

If this looks reasonable, I will update the CL for other architectures.

[ulan, 2013-11-20 09:31:36]

The change looks good. I am not sure how to verify that this covers all the
hard-coded constants expect testing. It is possible that we miss few places.

https://codereview.chromium.org/60763006/diff/30001/src/arm/builtins-arm.cc
File src/arm/builtins-arm.cc (right):

https://codereview.chromium.org/60763006/diff/30001/src/arm/builtins-arm.cc#n...
src/arm/builtins-arm.cc:1346: __ add(fp, sp, Operand(3 * kPointerSize));
Did you mean to remove this line?

[rmcilroy, 2013-11-20 11:17:05]

I have tested this via the testing of the (currently unfinished) OOL constant
pool CL I have.  In that CL I change the frame size, and these are all the
places I had to change the hard-coded constants to get it to pass all the V8
tests.  It's entirely possible that I've missed some others though, but I'm not
sure how else to find them

https://codereview.chromium.org/60763006/diff/30001/src/arm/builtins-arm.cc
File src/arm/builtins-arm.cc (right):

https://codereview.chromium.org/60763006/diff/30001/src/arm/builtins-arm.cc#n...
src/arm/builtins-arm.cc:1346: __ add(fp, sp, Operand(3 * kPointerSize));
On 2013/11/20 09:31:37, ulan wrote:
> Did you mean to remove this line?

Yes, good catch!  Merge error issue. Done.

[ulan, 2013-11-20 11:46:12]

LGTM

[rmcilroy, 2013-11-20 13:42:35]

On 2013/11/20 11:46:12, ulan wrote:
> LGTM

Thanks Ulan! I had a look through x64 and ia32 but it seems they don't have the
same issue with hard-coded constants in the asm, so will submit as is.

[rmcilroy, 2013-11-20 13:44:32]

Committed patchset #3 manually as r17925 (presubmit successful).