src/arm/lithium-codegen-arm.cc - Issue 60763006: Replace hard-coded stack frame size literals with StandardFrameConstants::kFixedFrameSizeFromFp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/lithium-codegen-arm.cc

Issue 60763006: Replace hard-coded stack frame size literals with StandardFrameConstants::kFixedFrameSizeFromFp (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Fix merge error Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm/lithium-codegen-arm.cc

diff --git a/src/arm/lithium-codegen-arm.cc b/src/arm/lithium-codegen-arm.cc

index 56717a29e129e19071133d6fecb60db19bfbad56..e718d10cd87ca6daef1100dea515a123cf18c029 100644

--- a/src/arm/lithium-codegen-arm.cc

+++ b/src/arm/lithium-codegen-arm.cc

@@ -260,7 +260,7 @@ bool LCodeGen::GenerateDeferredCode() {

__ stm(db_w, sp, cp.bit() | fp.bit() | lr.bit());

__ mov(scratch0(), Operand(Smi::FromInt(StackFrame::STUB)));

__ push(scratch0());

- __ add(fp, sp, Operand(2 * kPointerSize));

+ __ add(fp, sp, Operand(StandardFrameConstants::kFixedFrameSizeFromFp));

Comment(";;; Deferred code");

}

code->Generate();

@@ -325,7 +325,7 @@ bool LCodeGen::GenerateDeoptJumpTable() {

ASSERT(info()->IsStub());

__ mov(scratch0(), Operand(Smi::FromInt(StackFrame::STUB)));

__ push(scratch0());

- __ add(fp, sp, Operand(2 * kPointerSize));

+ __ add(fp, sp, Operand(StandardFrameConstants::kFixedFrameSizeFromFp));

__ mov(lr, Operand(pc), LeaveCC, al);

__ mov(pc, ip);

}

« no previous file with comments | « src/arm/frames-arm.h ('k') | src/arm/macro-assembler-arm.cc » ('j') | no next file with comments »