Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: tools/testing/dart/test_runner.dart

Issue 60763004: Print drt exitcode when we pass test but crash before exiting (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_runner.dart
===================================================================
--- tools/testing/dart/test_runner.dart (revision 30388)
+++ tools/testing/dart/test_runner.dart (working copy)
@@ -834,8 +834,11 @@
}
assert(containsPass);
if (exitCode != 0) {
- DebugLogger.warning("All tests passed, but exitCode != 0. "
- "($command)");
+ var message = "All tests passed, but exitCode != 0. "
+ "Actual exitcode: $exitCode. "
+ "($command)";
+ DebugLogger.warning(message);
+ diagnostics.add(message);
}
return (exitCode != 0 && !hasCrashed);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698