Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: tools/testing/dart/test_runner.dart

Issue 60763004: Print drt exitcode when we pass test but crash before exiting (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 /** 5 /**
6 * Classes and methods for executing tests. 6 * Classes and methods for executing tests.
7 * 7 *
8 * This module includes: 8 * This module includes:
9 * - Managing parallel execution of tests, including timeout checks. 9 * - Managing parallel execution of tests, including timeout checks.
10 * - Evaluating the output of each test as pass/fail/crash/timeout. 10 * - Evaluating the output of each test as pass/fail/crash/timeout.
(...skipping 816 matching lines...) Expand 10 before | Expand all | Expand 10 after
827 if (!containsFail && !containsPass) { 827 if (!containsFail && !containsPass) {
828 DebugLogger.warning("Test had neither 'FAIL' nor 'PASS' in stdout. " 828 DebugLogger.warning("Test had neither 'FAIL' nor 'PASS' in stdout. "
829 "($command)"); 829 "($command)");
830 return true; 830 return true;
831 } 831 }
832 if (containsFail) { 832 if (containsFail) {
833 return true; 833 return true;
834 } 834 }
835 assert(containsPass); 835 assert(containsPass);
836 if (exitCode != 0) { 836 if (exitCode != 0) {
837 DebugLogger.warning("All tests passed, but exitCode != 0. " 837 var message = "All tests passed, but exitCode != 0. "
838 "($command)"); 838 "Actual exitcode: $exitCode. "
839 "($command)";
840 DebugLogger.warning(message);
841 diagnostics.add(message);
839 } 842 }
840 return (exitCode != 0 && !hasCrashed); 843 return (exitCode != 0 && !hasCrashed);
841 } 844 }
842 DebugLogger.warning("Couldn't find 'Content-Type: text/plain' in output. " 845 DebugLogger.warning("Couldn't find 'Content-Type: text/plain' in output. "
843 "($command)."); 846 "($command).");
844 return true; 847 return true;
845 } 848 }
846 } 849 }
847 850
848 class HTMLBrowserCommandOutputImpl extends BrowserCommandOutputImpl { 851 class HTMLBrowserCommandOutputImpl extends BrowserCommandOutputImpl {
(...skipping 1367 matching lines...) Expand 10 before | Expand all | Expand 10 after
2216 } 2219 }
2217 } 2220 }
2218 2221
2219 void eventAllTestsDone() { 2222 void eventAllTestsDone() {
2220 for (var listener in _eventListener) { 2223 for (var listener in _eventListener) {
2221 listener.allDone(); 2224 listener.allDone();
2222 } 2225 }
2223 _allDone(); 2226 _allDone();
2224 } 2227 }
2225 } 2228 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698