Elim parent_window parameter from network_connect

Elim parent_window parameter from network_connect

We were passing a 'parent_window' parameter to the network_connect::ConnectToNetwork() in an effort to open network configuration dialogs from the desktop they were triggered from. This was never a good idea since gfx::NativeWindow is actually a pointer which may become invalid before the callback is triggered.

In practice this is unnecessary since we decided that all network configuration applies to the primary user, so we should always use the currently active desktop to host the dialog (which is what GetNativeWindow() does in ash_system_tray_delegate.cc).

BUG=413925
Committed: https://crrev.com/03f26fbfc374e0f2ff4f101a2d2472363ee860a7
Cr-Commit-Position: refs/heads/master@{#296969}

[stevenjb, 2014-09-25 18:05:31]

stevenjb@chromium.org changed reviewers:
+ armansito@chromium.org, sky@chromium.org

[sky, 2014-09-25 19:37:19]

LGTM

https://codereview.chromium.org/607613002/diff/1/ash/system/chromeos/network/...
File ash/system/chromeos/network/network_connect.h (right):

https://codereview.chromium.org/607613002/diff/1/ash/system/chromeos/network/...
ash/system/chromeos/network/network_connect.h:12: #include
"ui/gfx/native_widget_types.h"  // gfx::NativeWindow
Hopefully you can remove this now.

https://codereview.chromium.org/607613002/diff/1/ash/system/tray/system_tray_...
File ash/system/tray/system_tray_delegate.h (right):

https://codereview.chromium.org/607613002/diff/1/ash/system/tray/system_tray_...
ash/system/tray/system_tray_delegate.h:18: #include
"ui/gfx/native_widget_types.h"
And remove this now.

[stevenjb, 2014-09-25 20:14:36]

https://codereview.chromium.org/607613002/diff/1/ash/system/chromeos/network/...
File ash/system/chromeos/network/network_connect.h (right):

https://codereview.chromium.org/607613002/diff/1/ash/system/chromeos/network/...
ash/system/chromeos/network/network_connect.h:12: #include
"ui/gfx/native_widget_types.h"  // gfx::NativeWindow
On 2014/09/25 19:37:18, sky wrote:
> Hopefully you can remove this now.

Done.

https://codereview.chromium.org/607613002/diff/1/ash/system/tray/system_tray_...
File ash/system/tray/system_tray_delegate.h (right):

https://codereview.chromium.org/607613002/diff/1/ash/system/tray/system_tray_...
ash/system/tray/system_tray_delegate.h:18: #include
"ui/gfx/native_widget_types.h"
On 2014/09/25 19:37:18, sky wrote:
> And remove this now.

Done.

[stevenjb, 2014-09-26 16:42:50]

The CQ bit was checked by stevenjb@chromium.org

[commit-bot: I haz the power, 2014-09-26 16:43:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/607613002/20001

[commit-bot: I haz the power, 2014-09-26 17:28:55]

Committed patchset #2 (id:20001) as f282a03d6470d0c8386d15f490a26a18e192f2b2

[commit-bot: I haz the power, 2014-09-26 17:29:41]

Patchset 2 (id:??) landed as
https://crrev.com/03f26fbfc374e0f2ff4f101a2d2472363ee860a7
Cr-Commit-Position: refs/heads/master@{#296969}