ash/system/chromeos/network/network_state_list_detailed_view.cc - Issue 607613002: Elim parent_window parameter from network_connect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/system/chromeos/network/network_state_list_detailed_view.cc

Issue 607613002: Elim parent_window parameter from network_connect (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Elim includes Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ash/system/chromeos/network/network_state_list_detailed_view.cc

diff --git a/ash/system/chromeos/network/network_state_list_detailed_view.cc b/ash/system/chromeos/network/network_state_list_detailed_view.cc

index ed8a6e26bf565b0c84383650e36b48477e88a4c5..c7ff9fb665efbd3c707c466058a54d5530e7aaeb 100644

--- a/ash/system/chromeos/network/network_state_list_detailed_view.cc

+++ b/ash/system/chromeos/network/network_state_list_detailed_view.cc

@@ -271,7 +271,7 @@ void NetworkStateListDetailedView::OnViewClicked(views::View* sender) {

list_type_ == LIST_TYPE_VPN ?

ash::UMA_STATUS_AREA_CONNECT_TO_VPN :

ash::UMA_STATUS_AREA_CONNECT_TO_CONFIGURED_NETWORK);

- ash::network_connect::ConnectToNetwork(service_path, NULL);

+ ash::network_connect::ConnectToNetwork(service_path);

}