Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 607593002: Remove -webkit-border-fit (Closed)

Created:
6 years, 2 months ago by Xianzhu
Modified:
6 years, 2 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, blink-reviews-css, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, ed+blinkwatch_opera.com, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, rune+blink, rwlbuis
Project:
blink
Visibility:
Public.

Description

Remove -webkit-border-fit "Intent to remove" thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/6DTvWsADTL8 3 LGTM's from ojan@, jochen@ and abarth@. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183072

Patch Set 1 : #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -443 lines) Patch
D LayoutTests/fast/block/border-fit-with-right-alignment.html View Binary file 0 comments Download
D LayoutTests/fast/block/border-fit-with-right-alignment-expected.html View Binary file 0 comments Download
D LayoutTests/fast/borders/border-fit.html View 1 chunk +0 lines, -99 lines 0 comments Download
D LayoutTests/fast/borders/border-fit-2.html View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/fast/borders/border-fit-2-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/fast/borders/border-fit-empty.html View 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/fast/borders/border-fit-empty-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/css/first-letter-property-whitelist.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/fast/repaint/border-fit-lines.html View 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/fast/repaint/border-fit-lines-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/platform/linux/fast/borders/border-fit-expected.png View Binary file 0 comments Download
D LayoutTests/platform/linux/fast/repaint/border-fit-lines-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/platform/mac/fast/borders/border-fit-2-expected.png View Binary file 0 comments Download
D LayoutTests/platform/mac/fast/borders/border-fit-expected.png View 1 Binary file 0 comments Download
D LayoutTests/platform/mac/fast/borders/border-fit-expected.txt View 1 1 chunk +0 lines, -48 lines 0 comments Download
D LayoutTests/platform/win-xp/fast/repaint/border-fit-lines-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/platform/win/fast/borders/border-fit-2-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/borders/border-fit-expected.png View Binary file 0 comments Download
D LayoutTests/platform/win/fast/borders/border-fit-expected.txt View 1 chunk +0 lines, -48 lines 0 comments Download
M LayoutTests/svg/css/getComputedStyle-basic-expected.txt View 2 chunks +0 lines, -4 lines 0 comments Download
M LayoutTests/virtual/stable/webexposed/css-properties-as-js-properties-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/webexposed/css-properties-as-js-properties-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 1 2 chunks +0 lines, -5 lines 0 comments Download
M Source/core/css/CSSPrimitiveValueMappings.h View 1 chunk +0 lines, -30 lines 0 comments Download
M Source/core/css/CSSProperties.in View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/css/CSSValueKeywords.in View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/css/parser/BisonCSSParser-in.cpp View 1 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/css/resolver/StyleResolver.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/frame/UseCounter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBlockFlow.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/rendering/RenderBlockFlow.cpp View 1 2 chunks +0 lines, -72 lines 0 comments Download
M Source/core/rendering/RenderBox.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderObject.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/RenderObject.cpp View 1 2 chunks +0 lines, -6 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.h View 3 chunks +0 lines, -3 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/style/RenderStyleConstants.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/rendering/style/StyleRareNonInheritedData.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/rendering/style/StyleRareNonInheritedData.cpp View 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
Xianzhu
6 years, 2 months ago (2014-09-25 21:51:52 UTC) #4
pdr.
So much code removal! This is fantastic. Because of the high usage I don't think ...
6 years, 2 months ago (2014-09-26 03:21:04 UTC) #5
Xianzhu
Just got 3 LG's for "Intent to remove: -webkit-border-fit". PTAL :)
6 years, 2 months ago (2014-09-30 16:23:55 UTC) #6
pdr.
On 2014/09/30 16:23:55, Xianzhu wrote: > Just got 3 LG's for "Intent to remove: -webkit-border-fit". ...
6 years, 2 months ago (2014-09-30 19:11:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/607593002/40001
6 years, 2 months ago (2014-09-30 19:12:27 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/16405)
6 years, 2 months ago (2014-09-30 19:21:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/607593002/60001
6 years, 2 months ago (2014-09-30 22:06:28 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/29600)
6 years, 2 months ago (2014-10-01 01:23:30 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/607593002/60001
6 years, 2 months ago (2014-10-01 15:57:35 UTC) #17
commit-bot: I haz the power
6 years, 2 months ago (2014-10-01 16:46:08 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as 183072

Powered by Google App Engine
This is Rietveld 408576698