Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(743)

Issue 607553002: Added msvs_enable_winrt to enable creating Windows Store compatible projects for .dlls that are con… (Closed)

Created:
6 years, 2 months ago by coop
Modified:
6 years, 2 months ago
Reviewers:
scottmg
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

Added msvs_enable_winrt to enable creating Windows Store compatible projects for .dlls that are consumed by WinRT applications. Patch from coopp@microsoft.com. BUG= R=scottmg@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1985

Patch Set 1 #

Patch Set 2 : Added ARM to TargetMachine map for completeness #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -11 lines) Patch
M pylib/gyp/generator/msvs.py View 5 chunks +34 lines, -9 lines 0 comments Download
M pylib/gyp/msvs_emulation.py View 1 2 chunks +4 lines, -2 lines 1 comment Download
A test/win/enable-winrt/dllmain.cc View 1 chunk +30 lines, -0 lines 0 comments Download
A test/win/enable-winrt/enable-winrt.gyp View 1 chunk +42 lines, -0 lines 1 comment Download
A test/win/gyptest-link-enable-winrt.py View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
coop
I updated the test to have a proper check that prevents it from being run ...
6 years, 2 months ago (2014-09-25 15:39:08 UTC) #2
scottmg
I think we'll need the '3': 'ARM' thing bit in msvs_emulation, right? (Something seems to ...
6 years, 2 months ago (2014-09-25 16:19:06 UTC) #3
coop
On 2014/09/25 16:19:06, scottmg wrote: > I think we'll need the '3': 'ARM' thing bit ...
6 years, 2 months ago (2014-09-25 16:22:51 UTC) #4
coop
On 2014/09/25 16:22:51, coop wrote: > On 2014/09/25 16:19:06, scottmg wrote: > > I think ...
6 years, 2 months ago (2014-09-25 16:31:07 UTC) #5
scottmg
lgtm
6 years, 2 months ago (2014-09-25 16:46:31 UTC) #6
scottmg
Committed patchset #2 (id:20001) manually as 1985 (presubmit successful).
6 years, 2 months ago (2014-09-25 16:48:21 UTC) #7
scottmg
6 years, 2 months ago (2014-09-25 16:48:33 UTC) #8
Message was sent while issue was closed.
(i tweaked the formatting below on landing)

https://codereview.chromium.org/607553002/diff/20001/pylib/gyp/msvs_emulation.py
File pylib/gyp/msvs_emulation.py (right):

https://codereview.chromium.org/607553002/diff/20001/pylib/gyp/msvs_emulation...
pylib/gyp/msvs_emulation.py:482: prefix='/MACHINE:')
nit; align to (

https://codereview.chromium.org/607553002/diff/20001/test/win/enable-winrt/en...
File test/win/enable-winrt/enable-winrt.gyp (right):

https://codereview.chromium.org/607553002/diff/20001/test/win/enable-winrt/en...
test/win/enable-winrt/enable-winrt.gyp:30: 'msvs_settings':
nit; 2s and [ and { on previous line

Powered by Google App Engine
This is Rietveld 408576698