Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 607463002: Refactoring: Extract interface for VC in release scripts. (Closed)

Created:
6 years, 2 months ago by Michael Achenbach
Modified:
6 years, 2 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Refactoring: Extract interface for VC in release scripts. Also simplify tagging in merge_to_branch. BUG=chromium:410721 LOG=n R=jkummerow@chromium.org, tandrii@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24228

Patch Set 1 #

Total comments: 4

Patch Set 2 : Review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -76 lines) Patch
M tools/push-to-trunk/auto_tag.py View 5 chunks +6 lines, -12 lines 0 comments Download
M tools/push-to-trunk/bump_up_version.py View 1 chunk +1 line, -0 lines 0 comments Download
M tools/push-to-trunk/common_includes.py View 1 4 chunks +96 lines, -2 lines 0 comments Download
M tools/push-to-trunk/merge_to_branch.py View 8 chunks +8 lines, -32 lines 0 comments Download
M tools/push-to-trunk/push_to_trunk.py View 13 chunks +19 lines, -14 lines 0 comments Download
M tools/push-to-trunk/releases.py View 4 chunks +5 lines, -9 lines 0 comments Download
M tools/push-to-trunk/test_scripts.py View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Achenbach
PTAL. jkummerow for the changed tagging method in merge_to_branch.
6 years, 2 months ago (2014-09-25 11:35:00 UTC) #2
tandrii(chromium)
lgtm https://codereview.chromium.org/607463002/diff/1/tools/push-to-trunk/common_includes.py File tools/push-to-trunk/common_includes.py (right): https://codereview.chromium.org/607463002/diff/1/tools/push-to-trunk/common_includes.py#newcode263 tools/push-to-trunk/common_includes.py:263: raise Exception() any reason why not raise NotImplementedError
6 years, 2 months ago (2014-09-25 12:50:08 UTC) #3
Jakob Kummerow
lgtm https://codereview.chromium.org/607463002/diff/1/tools/push-to-trunk/merge_to_branch.py File tools/push-to-trunk/merge_to_branch.py (left): https://codereview.chromium.org/607463002/diff/1/tools/push-to-trunk/merge_to_branch.py#oldcode257 tools/push-to-trunk/merge_to_branch.py:257: print "svn revision: %s" % self["svn_revision"] It would ...
6 years, 2 months ago (2014-09-25 12:58:17 UTC) #4
Michael Achenbach
Done. https://codereview.chromium.org/607463002/diff/1/tools/push-to-trunk/common_includes.py File tools/push-to-trunk/common_includes.py (right): https://codereview.chromium.org/607463002/diff/1/tools/push-to-trunk/common_includes.py#newcode263 tools/push-to-trunk/common_includes.py:263: raise Exception() On 2014/09/25 12:50:08, tandrii wrote: > ...
6 years, 2 months ago (2014-09-25 13:13:48 UTC) #5
Michael Achenbach
6 years, 2 months ago (2014-09-25 13:25:26 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 24228 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698